Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Unified Diff: test/mjsunit/harmony/typedarrays.js

Issue 17572009: Update typed arrays behavior to match ES6 rev 15. Remove TO_POSITIVE_INTEGER and throw on negative … (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: CR feedback Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/harmony/dataview-accessors.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/typedarrays.js
diff --git a/test/mjsunit/harmony/typedarrays.js b/test/mjsunit/harmony/typedarrays.js
index e1048ecfaf36ba445d55bc7701b0e9f838a922ae..c699f647180fe1ae89257f9ca41257eb86b06a08 100644
--- a/test/mjsunit/harmony/typedarrays.js
+++ b/test/mjsunit/harmony/typedarrays.js
@@ -35,14 +35,15 @@ function TestByteLength(param, expectedByteLength) {
function TestArrayBufferCreation() {
TestByteLength(1, 1);
TestByteLength(256, 256);
- TestByteLength(-10, 0);
TestByteLength(2.567, 2);
- TestByteLength(-2.567, 0);
TestByteLength("abc", 0);
TestByteLength(0, 0);
+ assertThrows(function() { new ArrayBuffer(-10); }, RangeError);
+ assertThrows(function() { new ArrayBuffer(-2.567); }, RangeError);
+
/* TODO[dslomov]: Reenable the test
assertThrows(function() {
var ab1 = new ArrayBuffer(0xFFFFFFFFFFFF)
@@ -89,6 +90,7 @@ function TestArrayBufferSlice() {
TestSlice(0, 0, 1, 20);
TestSlice(100, 100, 0, 100);
TestSlice(100, 100, 0, 1000);
+
TestSlice(0, 100, 5, 1);
TestSlice(1, 100, -11, -10);
@@ -99,7 +101,7 @@ function TestArrayBufferSlice() {
TestSlice(10, 100, 90, "100");
TestSlice(10, 100, "90", "100");
- TestSlice(0, 100, 90, "abc");
+ TestSlice(0, 100, 90, "abc");
TestSlice(10, 100, "abc", 10);
TestSlice(10, 100, 0.96, 10.96);
@@ -107,7 +109,6 @@ function TestArrayBufferSlice() {
TestSlice(10, 100, 0.01, 10.01);
TestSlice(10, 100, 0.01, 10.96);
-
TestSlice(10, 100, 90);
TestSlice(10, 100, -10);
}
@@ -489,24 +490,15 @@ function TestDataViewConstructor() {
assertSame(256, d3c.byteOffset);
assertSame(0, d3c.byteLength);
- // weird args
- var d4 = new DataView(ab, -1);
+ var d4 = new DataView(ab, 1, 3.1415926);
assertSame(ab, d4.buffer);
- assertSame(0, d4.byteOffset);
- assertSame(256, d4.byteLength);
-
- var d5 = new DataView(ab, 1, -1);
- assertSame(ab, d5.buffer);
- assertSame(1, d5.byteOffset);
- assertSame(0, d5.byteLength);
-
- var d6 = new DataView(ab, 1, 3.1415926);
- assertSame(ab, d6.buffer);
- assertSame(1, d6.byteOffset);
- assertSame(3, d6.byteLength);
+ assertSame(1, d4.byteOffset);
+ assertSame(3, d4.byteLength);
// error cases
+ assertThrows(function() { new DataView(ab, -1); }, RangeError);
+ assertThrows(function() { new DataView(ab, 1, -1); }, RangeError);
assertThrows(function() { new DataView(); }, TypeError);
assertThrows(function() { new DataView([]); }, TypeError);
assertThrows(function() { new DataView(ab, 257); }, RangeError);
« no previous file with comments | « test/mjsunit/harmony/dataview-accessors.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698