Update typed arrays behavior to match ES6 rev 15. Remove TO_POSITIVE_INTEGER and throw on negative …

test/mjsunit/harmony/typedarrays.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 17 matching lines @@
 // ArrayBuffer
 
 function TestByteLength(param, expectedByteLength) {
   var ab = new ArrayBuffer(param);
   assertSame(expectedByteLength, ab.byteLength);
 }
 
 function TestArrayBufferCreation() {
   TestByteLength(1, 1);
   TestByteLength(256, 256);
-  TestByteLength(-10, 0);
   TestByteLength(2.567, 2);
-  TestByteLength(-2.567, 0);
 
   TestByteLength("abc", 0);
 
   TestByteLength(0, 0);
 
+  assertThrows(function() { new ArrayBuffer(-10); }, RangeError);
+  assertThrows(function() { new ArrayBuffer(-2.567); }, RangeError);
+
 /* TODO[dslomov]: Reenable the test
   assertThrows(function() {
     var ab1 = new ArrayBuffer(0xFFFFFFFFFFFF)
   }, RangeError);
 */
 
   var ab = new ArrayBuffer();
   assertSame(0, ab.byteLength);
 }
 
@@ skipping 26 matching lines @@
   var ab = new ArrayBuffer(1024);
   var ab1 = ab.slice(512, 1024);
   assertSame(512, ab1.byteLength);
 
   TestSlice(512, 1024, 512, 1024);
   TestSlice(512, 1024, 512);
 
   TestSlice(0, 0, 1, 20);
   TestSlice(100, 100, 0, 100);
   TestSlice(100, 100, 0, 1000);
+
   TestSlice(0, 100, 5, 1);
 
   TestSlice(1, 100, -11, -10);
   TestSlice(9, 100, -10, 99);
   TestSlice(0, 100, -10, 80);
   TestSlice(10, 100, 80, -10);
 
   TestSlice(10, 100, 90, "100");
   TestSlice(10, 100, "90", "100");
 
-  TestSlice(0, 100, 90, "abc");
+  TestSlice(0,  100, 90, "abc");
   TestSlice(10, 100, "abc", 10);
 
   TestSlice(10, 100, 0.96, 10.96);
   TestSlice(10, 100, 0.96, 10.01);
   TestSlice(10, 100, 0.01, 10.01);
   TestSlice(10, 100, 0.01, 10.96);
 
-
   TestSlice(10, 100, 90);
   TestSlice(10, 100, -10);
 }
 
 TestArrayBufferSlice();
 
 // Typed arrays
 
 function TestTypedArray(proto, elementSize, typicalElement) {
   var ab = new ArrayBuffer(256*elementSize);
@@ skipping 361 matching lines @@
   var d3b = new DataView(ab, 256, 0);
   assertSame(ab, d3b.buffer);
   assertSame(256, d3b.byteOffset);
   assertSame(0, d3b.byteLength);
 
   var d3c = new DataView(ab, 256);
   assertSame(ab, d3c.buffer);
   assertSame(256, d3c.byteOffset);
   assertSame(0, d3c.byteLength);
 
-  // weird args
-  var d4 = new DataView(ab, -1);
+  var d4 = new DataView(ab, 1, 3.1415926);
   assertSame(ab, d4.buffer);
-  assertSame(0, d4.byteOffset);
-  assertSame(256, d4.byteLength);
-
-  var d5 = new DataView(ab, 1, -1);
-  assertSame(ab, d5.buffer);
-  assertSame(1, d5.byteOffset);
-  assertSame(0, d5.byteLength);
-
-  var d6 = new DataView(ab, 1, 3.1415926);
-  assertSame(ab, d6.buffer);
-  assertSame(1, d6.byteOffset);
-  assertSame(3, d6.byteLength);
+  assertSame(1, d4.byteOffset);
+  assertSame(3, d4.byteLength);
 
 
   // error cases
+  assertThrows(function() { new DataView(ab, -1); }, RangeError);
+  assertThrows(function() { new DataView(ab, 1, -1); }, RangeError);
   assertThrows(function() { new DataView(); }, TypeError);
   assertThrows(function() { new DataView([]); }, TypeError);
   assertThrows(function() { new DataView(ab, 257); }, RangeError);
   assertThrows(function() { new DataView(ab, 1, 1024); }, RangeError);
 }
 
 TestDataViewConstructor();
 
 function TestDataViewPropertyTypeChecks() {
   var a = new DataView(new ArrayBuffer(10));
@@ skipping 46 matching lines @@
 TestArbitrary(new ArrayBuffer(256));
 for(i = 0; i < typedArrayConstructors.lenght; i++) {
   TestArbitary(new typedArrayConstructors[i](10));
 }
 TestArbitrary(new DataView(new ArrayBuffer(256)));
 
 
 // Test direct constructor call
 assertTrue(ArrayBuffer() instanceof ArrayBuffer);
 assertTrue(DataView(new ArrayBuffer()) instanceof DataView);