Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: src/runtime.js

Issue 17572009: Update typed arrays behavior to match ES6 rev 15. Remove TO_POSITIVE_INTEGER and throw on negative … (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: CR feedback Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/messages.js ('k') | src/typedarray.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 640 matching lines...) Expand 10 before | Expand all | Expand 10 after
651 651
652 var toString = x.toString; 652 var toString = x.toString;
653 if (IS_SPEC_FUNCTION(toString)) { 653 if (IS_SPEC_FUNCTION(toString)) {
654 var s = %_CallFunction(x, toString); 654 var s = %_CallFunction(x, toString);
655 if (%IsPrimitive(s)) return s; 655 if (%IsPrimitive(s)) return s;
656 } 656 }
657 657
658 throw %MakeTypeError('cannot_convert_to_primitive', []); 658 throw %MakeTypeError('cannot_convert_to_primitive', []);
659 } 659 }
660 660
661
662 // ECMA-262, section 8.6.2.6, page 28. 661 // ECMA-262, section 8.6.2.6, page 28.
663 function DefaultString(x) { 662 function DefaultString(x) {
664 var toString = x.toString; 663 var toString = x.toString;
665 if (IS_SPEC_FUNCTION(toString)) { 664 if (IS_SPEC_FUNCTION(toString)) {
666 var s = %_CallFunction(x, toString); 665 var s = %_CallFunction(x, toString);
667 if (%IsPrimitive(s)) return s; 666 if (%IsPrimitive(s)) return s;
668 } 667 }
669 668
670 var valueOf = x.valueOf; 669 var valueOf = x.valueOf;
671 if (IS_SPEC_FUNCTION(valueOf)) { 670 if (IS_SPEC_FUNCTION(valueOf)) {
672 var v = %_CallFunction(x, valueOf); 671 var v = %_CallFunction(x, valueOf);
673 if (%IsPrimitive(v)) return v; 672 if (%IsPrimitive(v)) return v;
674 } 673 }
675 674
676 throw %MakeTypeError('cannot_convert_to_primitive', []); 675 throw %MakeTypeError('cannot_convert_to_primitive', []);
677 } 676 }
678 677
678 function ToPositiveInteger(x, rangeErrorName) {
679 var i = TO_INTEGER(x);
680 if (i < 0) throw %MakeRangeError(rangeErrorName);
681 return i;
682 }
683
679 684
680 // NOTE: Setting the prototype for Array must take place as early as 685 // NOTE: Setting the prototype for Array must take place as early as
681 // possible due to code generation for array literals. When 686 // possible due to code generation for array literals. When
682 // generating code for a array literal a boilerplate array is created 687 // generating code for a array literal a boilerplate array is created
683 // that is cloned when running the code. It is essential that the 688 // that is cloned when running the code. It is essential that the
684 // boilerplate gets the right prototype. 689 // boilerplate gets the right prototype.
685 %FunctionSetPrototype($Array, new $Array(0)); 690 %FunctionSetPrototype($Array, new $Array(0));
OLDNEW
« no previous file with comments | « src/messages.js ('k') | src/typedarray.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698