Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: src/arraybuffer.js

Issue 17572009: Update typed arrays behavior to match ES6 rev 15. Remove TO_POSITIVE_INTEGER and throw on negative … (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: CR feedback Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/macros.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 13 matching lines...) Expand all
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 "use strict"; 28 "use strict";
29 29
30 var $ArrayBuffer = global.ArrayBuffer; 30 var $ArrayBuffer = global.ArrayBuffer;
31 31
32 // ------------------------------------------------------------------- 32 // -------------------------------------------------------------------
33 33
34 function ArrayBufferConstructor(byteLength) { // length = 1 34 function ArrayBufferConstructor(length) { // length = 1
35 if (%_IsConstructCall()) { 35 if (%_IsConstructCall()) {
36 var l = TO_POSITIVE_INTEGER(byteLength); 36 var byteLength = ToPositiveInteger(length, 'invalid_array_buffer_length');
37 %ArrayBufferInitialize(this, l); 37 %ArrayBufferInitialize(this, byteLength);
38 } else { 38 } else {
39 return new $ArrayBuffer(byteLength); 39 return new $ArrayBuffer(length);
40 } 40 }
41 } 41 }
42 42
43 function ArrayBufferGetByteLength() { 43 function ArrayBufferGetByteLength() {
44 if (!IS_ARRAYBUFFER(this)) { 44 if (!IS_ARRAYBUFFER(this)) {
45 throw MakeTypeError('incompatible_method_receiver', 45 throw MakeTypeError('incompatible_method_receiver',
46 ['ArrayBuffer.prototype.byteLength', this]); 46 ['ArrayBuffer.prototype.byteLength', this]);
47 } 47 }
48 return %ArrayBufferGetByteLength(this); 48 return %ArrayBufferGetByteLength(this);
49 } 49 }
(...skipping 13 matching lines...) Expand all
63 first = MathMin(relativeStart, this.byteLength); 63 first = MathMin(relativeStart, this.byteLength);
64 } 64 }
65 var relativeEnd = IS_UNDEFINED(end) ? this.byteLength : TO_INTEGER(end); 65 var relativeEnd = IS_UNDEFINED(end) ? this.byteLength : TO_INTEGER(end);
66 var fin; 66 var fin;
67 if (relativeEnd < 0) { 67 if (relativeEnd < 0) {
68 fin = MathMax(this.byteLength + relativeEnd, 0); 68 fin = MathMax(this.byteLength + relativeEnd, 0);
69 } else { 69 } else {
70 fin = MathMin(relativeEnd, this.byteLength); 70 fin = MathMin(relativeEnd, this.byteLength);
71 } 71 }
72 72
73 if (fin < first) {
74 fin = first;
75 }
73 var newLen = fin - first; 76 var newLen = fin - first;
74 // TODO(dslomov): implement inheritance 77 // TODO(dslomov): implement inheritance
75 var result = new $ArrayBuffer(newLen); 78 var result = new $ArrayBuffer(newLen);
76 79
77 %ArrayBufferSliceImpl(this, result, first); 80 %ArrayBufferSliceImpl(this, result, first);
78 return result; 81 return result;
79 } 82 }
80 83
81 function SetUpArrayBuffer() { 84 function SetUpArrayBuffer() {
82 %CheckIsBootstrapping(); 85 %CheckIsBootstrapping();
83 86
84 // Set up the ArrayBuffer constructor function. 87 // Set up the ArrayBuffer constructor function.
85 %SetCode($ArrayBuffer, ArrayBufferConstructor); 88 %SetCode($ArrayBuffer, ArrayBufferConstructor);
86 %FunctionSetPrototype($ArrayBuffer, new $Object()); 89 %FunctionSetPrototype($ArrayBuffer, new $Object());
87 90
88 // Set up the constructor property on the ArrayBuffer prototype object. 91 // Set up the constructor property on the ArrayBuffer prototype object.
89 %SetProperty($ArrayBuffer.prototype, "constructor", $ArrayBuffer, DONT_ENUM); 92 %SetProperty($ArrayBuffer.prototype, "constructor", $ArrayBuffer, DONT_ENUM);
90 93
91 InstallGetter($ArrayBuffer.prototype, "byteLength", ArrayBufferGetByteLength); 94 InstallGetter($ArrayBuffer.prototype, "byteLength", ArrayBufferGetByteLength);
92 95
93 InstallFunctions($ArrayBuffer.prototype, DONT_ENUM, $Array( 96 InstallFunctions($ArrayBuffer.prototype, DONT_ENUM, $Array(
94 "slice", ArrayBufferSlice 97 "slice", ArrayBufferSlice
95 )); 98 ));
96 } 99 }
97 100
98 SetUpArrayBuffer(); 101 SetUpArrayBuffer();
99 102
100 103
OLDNEW
« no previous file with comments | « no previous file | src/macros.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698