Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1757193002: Add test cases for Clamp and Repeat tiles. (Closed)

Created:
4 years, 9 months ago by herb_g
Modified:
4 years, 9 months ago
Reviewers:
mtklein, mtklein_C, reed1
CC:
f(malita), reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Repeat tiler working with dx = 1 #

Patch Set 3 : Dubious comments. #

Patch Set 4 : Working test #

Patch Set 5 : Add tests for the tile spans. #

Patch Set 6 : Compiler issues 1 #

Patch Set 7 : Simplify span breakAt usage, by making breakAt consistant for +/- dx. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -40 lines) Patch
M src/core/SkLinearBitmapPipeline.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkLinearBitmapPipeline_core.h View 1 2 3 4 5 6 5 chunks +26 lines, -6 lines 0 comments Download
M src/core/SkLinearBitmapPipeline_tile.h View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M tests/SkLinearBitmapPipelineTest.cpp View 1 2 3 4 5 6 1 chunk +215 lines, -32 lines 0 comments Download

Messages

Total messages: 32 (12 generated)
herb_g
Repeat tiler working with dx = 1
4 years, 9 months ago (2016-03-03 03:02:59 UTC) #2
herb_g
Dubious comments.
4 years, 9 months ago (2016-03-03 19:58:04 UTC) #3
herb_g
Working test
4 years, 9 months ago (2016-03-03 22:27:54 UTC) #4
herb_g
4 years, 9 months ago (2016-03-03 22:33:30 UTC) #7
mtklein
let's split the bug fixes from the refactor. hard to follow together.
4 years, 9 months ago (2016-03-04 13:33:26 UTC) #8
herb_g
Add tests for the tile spans.
4 years, 9 months ago (2016-03-04 19:41:38 UTC) #9
herb_g
The file splitting part of this CL is checked in. Here are the test cases ...
4 years, 9 months ago (2016-03-04 19:46:23 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757193002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757193002/80001
4 years, 9 months ago (2016-03-04 19:46:48 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/6877)
4 years, 9 months ago (2016-03-04 19:50:13 UTC) #14
herb_g
Compiler issues 1
4 years, 9 months ago (2016-03-04 21:36:40 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757193002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757193002/100001
4 years, 9 months ago (2016-03-04 21:37:14 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 22:04:30 UTC) #19
herb_g
Passing CQ tests. PTAL
4 years, 9 months ago (2016-03-04 22:07:38 UTC) #20
herb_g
Simplify span breakAt usage, by making breakAt consistant for +/- dx.
4 years, 9 months ago (2016-03-05 23:43:54 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757193002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757193002/120001
4 years, 9 months ago (2016-03-05 23:44:39 UTC) #23
herb_g
Making breakAt consistent for +/- dx simplified all the -1 nonsense at the call sites. ...
4 years, 9 months ago (2016-03-05 23:45:59 UTC) #24
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-05 23:53:50 UTC) #26
mtklein_C
lgtm
4 years, 9 months ago (2016-03-07 16:38:06 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757193002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757193002/120001
4 years, 9 months ago (2016-03-07 16:52:56 UTC) #30
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 17:17:50 UTC) #32
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/c60fee0f15c73137c4e335de04e9ca06e131b110

Powered by Google App Engine
This is Rietveld 408576698