chrome/browser/engagement/site_engagement_service.h - Issue 1757163002: [ImportantSites] JNI bindings for CBD filtering and Important Sites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service.h

Issue 1757163002: [ImportantSites] JNI bindings for CBD filtering and Important Sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added ImportantSitesUtil, cleaned up Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/preferences/important_sites_util_unittest.cc ('K') | « chrome/browser/android/preferences/pref_service_bridge.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_service.h

diff --git a/chrome/browser/engagement/site_engagement_service.h b/chrome/browser/engagement/site_engagement_service.h

index 4cfdc78a6f7d6891be8c25f2a1993f5be06fe73c..f520fc78fb7395136164c03523e1d046e2bebbee 100644

--- a/chrome/browser/engagement/site_engagement_service.h

+++ b/chrome/browser/engagement/site_engagement_service.h

@@ -127,6 +127,7 @@ class SiteEngagementScore {

friend class SiteEngagementHelperTest;

friend class SiteEngagementScoreTest;

friend class SiteEngagementServiceTest;

+ friend class ImportantSitesUtilTest;

// Array holding the values corresponding to each item in Variation array.

static double param_values[];

@@ -276,6 +277,7 @@ class SiteEngagementService : public KeyedService,

FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, EngagementLevel);

FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, ScoreDecayHistograms);

FRIEND_TEST_ALL_PREFIXES(AppBannerSettingsHelperTest, SiteEngagementTrigger);

+ FRIEND_TEST_ALL_PREFIXES(ImportantSitesUtilTest, NotificationsThenEngagement);

// Only used in tests.

SiteEngagementService(Profile* profile, scoped_ptr<base::Clock> clock);