Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2007)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 17571018: Reland fast tab closure behind a flag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Diff against original patch Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index dec5ac81df4d671cf1acc0910d7164f5e758827c..3d7ea91d3ecd35612030b63f1e67444bc713c964 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1815,15 +1815,20 @@ bool BrowserView::CanClose() {
if (!browser_->ShouldCloseWindow())
return false;
+ bool fast_tab_closing_enabled =
+ CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableFastUnload);
+
if (!browser_->tab_strip_model()->empty()) {
// Tab strip isn't empty. Hide the frame (so it appears to have closed
// immediately) and close all the tabs, allowing the renderers to shut
// down. When the tab strip is empty we'll be called back again.
frame_->Hide();
browser_->OnWindowClosing();
- browser_->tab_strip_model()->CloseAllTabs();
+ if (fast_tab_closing_enabled)
+ browser_->tab_strip_model()->CloseAllTabs();
return false;
- } else if (!browser_->HasCompletedUnloadProcessing()) {
+ } else if (fast_tab_closing_enabled &&
+ !browser_->HasCompletedUnloadProcessing()) {
// The browser needs to finish running unload handlers.
// Hide the frame (so it appears to have closed immediately), and
// the browser will call us back again when it is ready to close.

Powered by Google App Engine
This is Rietveld 408576698