build/args/blimp.gn - Issue 1757093002: Create gn arg templates for use with blimp builds. Update build doc.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/args/blimp.gn

Issue 1757093002: Create gn arg templates for use with blimp builds. Update build doc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Create gn arg templates for blimp builds. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Base GN arg template for blimp.

	2 # Shared development settings for blimp engine and client.

	3

	4 is_debug = true

	5 is_clang = true

	6 symbol_level = 1 # Use -g1 instead of -g2

	7 use_goma = true
	Dirk Pranke 2016/03/02 23:57:32 I don't really think we should check this file in I don't really think we should check this file in as-is, for the following reasons: 1. None of these flags are specific to blimp. 2. is_debug=true and is_clang=true by default on Linux (i.e., you don't need to specify these) (is_clang=false on Android, so that might actually be confusing). 3. I'm not really sure what you think you're saving by using -g1 instead of -g2 4. If I saw 'blimp.gn' I would assume that this was "the settings I want to use to build blimp". But, apparently, that's ambiguous. If you really want to check in something like this, I would call it blimp_dev.gn or something.
OLD	NEW

« no previous file with comments | « blimp/docs/build.md ('k') | build/args/blimp_client.gn » ('j') | build/args/blimp_client.gn » ('J')