Create gn arg templates for use with blimp builds. Update build doc.

Create gn arg templates for use with blimp builds. Update build doc.

Currently all args must be manually set per output blimp build. Blimp already uses 3 common development builds.

Using templates to define args would allow for developers to keep their args in sync more easily and would simplify blimp's gn build instructions.

BUG=

Committed: https://crrev.com/b83c37c2c149d27ffadde5f93c7b5840fb475a34
Cr-Commit-Position: refs/heads/master@{#379325}

[Jess, 2016-03-02 23:11:10]

Description was changed from

==========
Create gn arg templates for use with blimp builds. Update build doc.

Currently all args must be manually set per output blimp build. Blimp already
uses 3 common development builds.

Using templates to define args would allow for developers to keep their args
in sync more easily and would simplify blimp's gn build instructions.

Fix gn style errors.


Create tip blimp arg templates and instructions.


Create blimp gn template file.

BUG=
==========

to

==========
Create gn arg templates for use with blimp builds. Update build doc.

Currently all args must be manually set per output blimp build. Blimp already
uses 3 common development builds.

Using templates to define args would allow for developers to keep their args in
sync more easily and would simplify blimp's gn build instructions.

BUG=
==========

[Jess, 2016-03-02 23:11:10]

jessicag@chromium.org changed reviewers:
+ dpranke@chromium.org, maniscalco@chromium.org

[Jess, 2016-03-02 23:17:25]

One open issue is that blimp.gn is really just a set of developer build options
that we happen to treat as default, rather than a set of universal options for
blimp.

One thought is to instead use blimp_dev_settings.gn to bundle these up as an
optional and separate import to make them easier to replace.

I wanted to resolve this question before looping in a reviewer for the docs
change.

[Dirk Pranke, 2016-03-02 23:57:33]

Since these are the first //build/args files we're looking at, we don't have any
great style recommendations.

So, I'm making them up as I go :)

If any of my thoughts feel wrong, let me know and we can discuss further.

https://codereview.chromium.org/1757093002/diff/1/build/args/blimp.gn
File build/args/blimp.gn (right):

https://codereview.chromium.org/1757093002/diff/1/build/args/blimp.gn#newcode7
build/args/blimp.gn:7: use_goma = true
I don't really think we should check this file in as-is, for the following
reasons:

1. None of these flags are specific to blimp.

2. is_debug=true and is_clang=true by default on Linux (i.e., you don't need to
specify these) (is_clang=false on Android, so that might actually be confusing).

3. I'm not really sure what you think you're saving by using -g1 instead of -g2

4. If I saw 'blimp.gn' I would assume that this was "the settings I want to use
to build blimp". But, apparently, that's ambiguous. If you really want to check
in something like this, I would call it blimp_dev.gn or something.

https://codereview.chromium.org/1757093002/diff/1/build/args/blimp_client.gn
File build/args/blimp_client.gn (right):

https://codereview.chromium.org/1757093002/diff/1/build/args/blimp_client.gn#...
build/args/blimp_client.gn:11: is_component_build = true
is_component_build=true is more of a developer-convenience thing than a
needs-to-be-set-for-things-to-build-correctly thing, yes?

[Jess, 2016-03-03 18:06:50]

jessicag@chromium.org changed reviewers:
+ dtrainor@chromium.org, wez@chromium.org

[Jess, 2016-03-03 18:06:50]

jessicag@chromium.org changed required reviewers:
+ dpranke@chromium.org, dtrainor@chromium.org, maniscalco@chromium.org,
wez@chromium.org

[Jess, 2016-03-03 18:10:23]

After talking with Nick, I've removed the shared args and updated the comments
and docs accordingly.

Adding David and Wez to comment on the client and engine build args.

David, could you comment on is_component_build?

Wez, is there a benefit for engine development to have both a containerized
build and a (non-default args) bare build?

[brettw, 2016-03-03 18:35:56]

brettw@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2016-03-03 18:35:57]

https://codereview.chromium.org/1757093002/diff/20001/build/args/blimp_client.gn
File build/args/blimp_client.gn (right):

https://codereview.chromium.org/1757093002/diff/20001/build/args/blimp_client...
build/args/blimp_client.gn:3: # Copy to arg.gn in out directory and run gn gen
on the directory to use.
This should say run "gn args out/mydir" and type:
  import("//build/args/blimp_client.gn")
Users should not copy these files.

[Jess, 2016-03-03 18:49:04]

https://codereview.chromium.org/1757093002/diff/20001/build/args/blimp_client.gn
File build/args/blimp_client.gn (right):

https://codereview.chromium.org/1757093002/diff/20001/build/args/blimp_client...
build/args/blimp_client.gn:3: # Copy to arg.gn in out directory and run gn gen
on the directory to use.
On 2016/03/03 18:35:56, brettw wrote:
> This should say run "gn args out/mydir" and type:
>   import("//build/args/blimp_client.gn")
> Users should not copy these files.

Updated this line to reflect the example below that has the same effect.

[Dirk Pranke, 2016-03-03 19:19:51]

On 2016/03/03 18:35:57, brettw wrote:
>
https://codereview.chromium.org/1757093002/diff/20001/build/args/blimp_client.gn
> File build/args/blimp_client.gn (right):
> 
>
https://codereview.chromium.org/1757093002/diff/20001/build/args/blimp_client...
> build/args/blimp_client.gn:3: # Copy to arg.gn in out directory and run gn gen
> on the directory to use.
> This should say run "gn args out/mydir" and type:
>   import("//build/args/blimp_client.gn")
> Users should not copy these files.

We need to come up with a better way of doing this ...

[brettw, 2016-03-03 23:37:32]

This LGTM but you should probably wait fir Dirk also.

[Wez, 2016-03-04 00:31:35]

On 2016/03/03 18:10:23, Jess wrote:
> After talking with Nick, I've removed the shared args and updated the comments
> and docs accordingly.
> 
> Adding David and Wez to comment on the client and engine build args.
> 
> David, could you comment on is_component_build?
> 
> Wez, is there a benefit for engine development to have both a containerized
> build and a (non-default args) bare build?

I don't think there is while containerized builds have _fewer_ dependencies, no
- none of what you're cutting out impacts development, AFAICT.

LGTM

[maniscalco, 2016-03-04 00:45:36]

On 2016/03/04 00:31:35, Wez wrote:
> On 2016/03/03 18:10:23, Jess wrote:
> > After talking with Nick, I've removed the shared args and updated the
comments
> > and docs accordingly.
> > 
> > Adding David and Wez to comment on the client and engine build args.
> > 
> > David, could you comment on is_component_build?
> > 
> > Wez, is there a benefit for engine development to have both a containerized
> > build and a (non-default args) bare build?
> 
> I don't think there is while containerized builds have _fewer_ dependencies,
no
> - none of what you're cutting out impacts development, AFAICT.
> 
> LGTM

Jess, just to confirm, if there's no need for having a non-containerized engine
build as I believe wez@ just indicated, we can merge the blimp_engine.gn and
blimp_engine_containerized.gn files into one blimp_engine.gn right?  Assuming
yes, this LGTM.

[Jess, 2016-03-04 01:30:52]

Updated to provide a single template for all engine build args, including build
instructions doc. Nice to have this moving towards greater simplicity.

[maniscalco, 2016-03-04 01:34:27]

Patch set #4 LGTM with one nit.

https://codereview.chromium.org/1757093002/diff/60001/build/args/blimp_engine.gn
File build/args/blimp_engine.gn (right):

https://codereview.chromium.org/1757093002/diff/60001/build/args/blimp_engine...
build/args/blimp_engine.gn:1: # GN args template for a blimp engine. Works
within a docker container
nit: need a period at the end of this last sentence.

[David Trainor- moved to gerrit, 2016-03-04 05:20:02]

lgtm

[Dirk Pranke, 2016-03-04 05:26:49]

lgtm.

[Jess, 2016-03-04 17:48:26]

The CQ bit was checked by jessicag@chromium.org

[Jess, 2016-03-04 17:48:27]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
wez@chromium.org, dpranke@chromium.org, dtrainor@chromium.org,
maniscalco@chromium.org
Link to the patchset: https://codereview.chromium.org/1757093002/#ps80001
(title: "Add missed period to comment.")

[commit-bot: I haz the power, 2016-03-04 17:48:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1757093002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1757093002/80001

[commit-bot: I haz the power, 2016-03-04 17:50:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 17:50:22]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Jess, 2016-03-04 18:38:14]

The CQ bit was checked by jessicag@chromium.org

[Jess, 2016-03-04 18:38:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, dtrainor@chromium.org, brettw@chromium.org,
maniscalco@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/1757093002/#ps100001
(title: "Address merge conflicts blocking patch.")

[commit-bot: I haz the power, 2016-03-04 18:38:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1757093002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1757093002/100001

[commit-bot: I haz the power, 2016-03-04 19:05:08]

Description was changed from

==========
Create gn arg templates for use with blimp builds. Update build doc.

Currently all args must be manually set per output blimp build. Blimp already
uses 3 common development builds.

Using templates to define args would allow for developers to keep their args in
sync more easily and would simplify blimp's gn build instructions.

BUG=
==========

to

==========
Create gn arg templates for use with blimp builds. Update build doc.

Currently all args must be manually set per output blimp build. Blimp already
uses 3 common development builds.

Using templates to define args would allow for developers to keep their args in
sync more easily and would simplify blimp's gn build instructions.

BUG=
==========

[commit-bot: I haz the power, 2016-03-04 19:05:09]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-04 19:06:07]

Description was changed from

==========
Create gn arg templates for use with blimp builds. Update build doc.

Currently all args must be manually set per output blimp build. Blimp already
uses 3 common development builds.

Using templates to define args would allow for developers to keep their args in
sync more easily and would simplify blimp's gn build instructions.

BUG=
==========

to

==========
Create gn arg templates for use with blimp builds. Update build doc.

Currently all args must be manually set per output blimp build. Blimp already
uses 3 common development builds.

Using templates to define args would allow for developers to keep their args in
sync more easily and would simplify blimp's gn build instructions.

BUG=

Committed: https://crrev.com/b83c37c2c149d27ffadde5f93c7b5840fb475a34
Cr-Commit-Position: refs/heads/master@{#379325}
==========

[commit-bot: I haz the power, 2016-03-04 19:06:09]

Patchset 6 (id:??) landed as
https://crrev.com/b83c37c2c149d27ffadde5f93c7b5840fb475a34
Cr-Commit-Position: refs/heads/master@{#379325}