Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1757043002: Remove unused CFX_GrowOnlyPool. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused CFX_GrowOnlyPool. The CFX_GrowOnlyPool class is never used, removed. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/91f7f3fa6a6d62ed0ce819c3286b0ffe6eddedbc

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -70 lines) Patch
M core/include/fxcrt/fx_memory.h View 1 1 chunk +0 lines, -28 lines 0 comments Download
M core/src/fxcrt/fx_basic_memmgr.cpp View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-03-02 19:58:34 UTC) #2
Tom Sepez
https://codereview.chromium.org/1757043002/diff/1/core/include/fxcrt/fx_memory.h File core/include/fxcrt/fx_memory.h (left): https://codereview.chromium.org/1757043002/diff/1/core/include/fxcrt/fx_memory.h#oldcode72 core/include/fxcrt/fx_memory.h:72: #define FX_TryRealloc(type, ptr, size) \ Hate to say this, ...
4 years, 9 months ago (2016-03-02 20:28:07 UTC) #3
dsinclair
https://codereview.chromium.org/1757043002/diff/1/core/include/fxcrt/fx_memory.h File core/include/fxcrt/fx_memory.h (left): https://codereview.chromium.org/1757043002/diff/1/core/include/fxcrt/fx_memory.h#oldcode72 core/include/fxcrt/fx_memory.h:72: #define FX_TryRealloc(type, ptr, size) \ On 2016/03/02 20:28:07, Tom ...
4 years, 9 months ago (2016-03-02 20:55:36 UTC) #4
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-02 22:59:12 UTC) #5
dsinclair
4 years, 9 months ago (2016-03-02 23:58:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
91f7f3fa6a6d62ed0ce819c3286b0ffe6eddedbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698