Document confusing threading requirements in ServiceWorkerContext(Wrapper).

Document confusing threading requirements in ServiceWorkerContext(Wrapper).

This adds comments to all public methods in ServiceWorkerContext and
ServiceWorkerContextWrapper explaining on which thread the method can be
called, and on which thread its callback will be called.

Also fixes some inconsistencies where for some methods a callback could
be sometimes called on different threads.

BUG=591427
Committed: https://crrev.com/e51e01d8b2c430f2f327692e2b98006b8dc0763d
Cr-Commit-Position: refs/heads/master@{#379145}

[Marijn Kruisselbrink, 2016-03-02 20:31:17]

mek@chromium.org changed reviewers:
+ falken@chromium.org

[falken, 2016-03-03 06:44:13]

lgtm to add documentation, I also commented on the bug we probably should just
make this consistently on the IO thread.

[Marijn Kruisselbrink, 2016-03-03 21:32:15]

mek@chromium.org changed reviewers:
+ avi@chromium.org

[Marijn Kruisselbrink, 2016-03-03 21:32:15]

+avi for content/public OWNERS

[Avi (use Gerrit), 2016-03-03 21:39:20]

1) Love the comments.
2) Are all those comments enforced in code with DCHECK_CURRENTLY_ON?

[Marijn Kruisselbrink, 2016-03-03 21:42:22]

On 2016/03/03 at 21:39:20, avi wrote:
> 1) Love the comments.
> 2) Are all those comments enforced in code with DCHECK_CURRENTLY_ON?

Yes, these comments are documenting existing DCHECK_CURRENTLY_ON checks in the
code (at least the ones that say methods can only be called on specific
threads).

[Avi (use Gerrit), 2016-03-03 21:43:19]

On 2016/03/03 21:42:22, Marijn Kruisselbrink wrote:
> On 2016/03/03 at 21:39:20, avi wrote:
> > 1) Love the comments.
> > 2) Are all those comments enforced in code with DCHECK_CURRENTLY_ON?
> 
> Yes, these comments are documenting existing DCHECK_CURRENTLY_ON checks in the
> code (at least the ones that say methods can only be called on specific
> threads).

👍

[Avi (use Gerrit), 2016-03-03 21:43:27]

On 2016/03/03 21:43:19, Avi wrote:
> On 2016/03/03 21:42:22, Marijn Kruisselbrink wrote:
> > On 2016/03/03 at 21:39:20, avi wrote:
> > > 1) Love the comments.
> > > 2) Are all those comments enforced in code with DCHECK_CURRENTLY_ON?
> > 
> > Yes, these comments are documenting existing DCHECK_CURRENTLY_ON checks in
the
> > code (at least the ones that say methods can only be called on specific
> > threads).
> 
> 👍

LGTM

[Marijn Kruisselbrink, 2016-03-03 21:48:09]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2016-03-03 21:48:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1757023003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1757023003/1

[Marijn Kruisselbrink, 2016-03-03 21:48:52]

Description was changed from

==========
Document confusing threading requirements in ServiceWorkerContextCore.

This adds comments to all public methods in ServiceWorkerContext and
ServiceWorkerContextCore explaining on which thread the method can be
called, and on which thread its callback will be called.

Also fixes some inconsistencies where for some methods a callback could
be sometimes called on different threads.

BUG=591427
==========

to

==========
Document confusing threading requirements in ServiceWorkerContext(Wrapper).

This adds comments to all public methods in ServiceWorkerContext and
ServiceWorkerContextWrapper explaining on which thread the method can be
called, and on which thread its callback will be called.

Also fixes some inconsistencies where for some methods a callback could
be sometimes called on different threads.

BUG=591427
==========

[Marijn Kruisselbrink, 2016-03-03 21:49:00]

The CQ bit was unchecked by mek@chromium.org

[Marijn Kruisselbrink, 2016-03-03 21:49:03]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2016-03-03 21:49:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1757023003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1757023003/1

[commit-bot: I haz the power, 2016-03-04 00:05:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-04 00:07:22]

Description was changed from

==========
Document confusing threading requirements in ServiceWorkerContext(Wrapper).

This adds comments to all public methods in ServiceWorkerContext and
ServiceWorkerContextWrapper explaining on which thread the method can be
called, and on which thread its callback will be called.

Also fixes some inconsistencies where for some methods a callback could
be sometimes called on different threads.

BUG=591427
==========

to

==========
Document confusing threading requirements in ServiceWorkerContext(Wrapper).

This adds comments to all public methods in ServiceWorkerContext and
ServiceWorkerContextWrapper explaining on which thread the method can be
called, and on which thread its callback will be called.

Also fixes some inconsistencies where for some methods a callback could
be sometimes called on different threads.

BUG=591427

Committed: https://crrev.com/e51e01d8b2c430f2f327692e2b98006b8dc0763d
Cr-Commit-Position: refs/heads/master@{#379145}
==========

[commit-bot: I haz the power, 2016-03-04 00:07:23]

Patchset 1 (id:??) landed as
https://crrev.com/e51e01d8b2c430f2f327692e2b98006b8dc0763d
Cr-Commit-Position: refs/heads/master@{#379145}