Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1756963002: Measure the many aspects of HTMLAllCollection (Closed)

Created:
4 years, 9 months ago by philipj_slow
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure the many aspects of HTMLAllCollection Multiple spec changes to HTMLAllCollection are under discussion: https://github.com/whatwg/html/issues/775 https://github.com/whatwg/html/pull/780 To help inform the discussion and estimate risk, measure some of the aspects that are currently not per spec, as well as a few extra bits for comparison purposes. BUG=591605 Committed: https://crrev.com/69256151c9e821963929cf29a778b5df66027023 Cr-Commit-Position: refs/heads/master@{#379484}

Patch Set 1 #

Patch Set 2 : add M50 comment #

Patch Set 3 : go crazy, measure everything #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/document-all-use-counters.html View 1 2 1 chunk +87 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp View 1 2 2 chunks +23 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756963002/1
4 years, 9 months ago (2016-03-02 18:02:20 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 20:32:59 UTC) #4
philipj_slow
PTAL
4 years, 9 months ago (2016-03-03 18:12:15 UTC) #7
domenic
On 2016/03/03 at 18:12:15, philipj wrote: > PTAL The 0 argument form is actually very ...
4 years, 9 months ago (2016-03-03 18:14:42 UTC) #8
philipj_slow
On 2016/03/03 18:14:42, domenic wrote: > On 2016/03/03 at 18:12:15, philipj wrote: > > PTAL ...
4 years, 9 months ago (2016-03-03 18:40:26 UTC) #9
philipj_slow
I've expanded the scope of this CL to measure everything that could potentially be useful ...
4 years, 9 months ago (2016-03-05 17:49:43 UTC) #13
Ilya Sherman
histograms.xml lgtm
4 years, 9 months ago (2016-03-06 03:42:54 UTC) #14
haraken
bindings LGTM
4 years, 9 months ago (2016-03-06 03:51:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756963002/40001
4 years, 9 months ago (2016-03-06 05:02:09 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-06 05:08:23 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-06 05:09:48 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/69256151c9e821963929cf29a778b5df66027023
Cr-Commit-Position: refs/heads/master@{#379484}

Powered by Google App Engine
This is Rietveld 408576698