Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1756933003: Revert of Fix param_name for Properties. (Closed)

Created:
4 years, 9 months ago by martiniss
Modified:
4 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/recipes-py@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

Revert of Fix param_name for Properties. (patchset #1 id:1 of https://codereview.chromium.org/1755593003/ ) Reason for revert: Broke findit recipe which uses param_name. Original issue's description: > Fix param_name for Properties. > > This allows for you to have a property 'event.patchset', which gets put into > a python parameter name "event_patchset", for example. This behavior was > previously broken. Added a working test for it. > > BUG=591172 > > Committed: https://github.com/luci/recipes-py/commit/b044190384a6b5330fbbda7d922f4ead3cc88fb8 TBR=iannucci@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591172 Committed: https://github.com/luci/recipes-py/commit/3954063a6f438cff11211e8e9878e5587565a4f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -31 lines) Patch
M recipe_engine/loader.py View 3 chunks +11 lines, -25 lines 0 comments Download
M recipe_engine/unittests/loader_test.py View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
martiniss
Created Revert of Fix param_name for Properties.
4 years, 9 months ago (2016-03-02 22:02:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756933003/1
4 years, 9 months ago (2016-03-02 22:02:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/recipes-py/commit/3954063a6f438cff11211e8e9878e5587565a4f1
4 years, 9 months ago (2016-03-02 22:03:01 UTC) #4
iannucci
Hm... how was this not caught by the tests? Could we add more tests now ...
4 years, 9 months ago (2016-03-02 22:45:18 UTC) #5
martiniss
4 years, 9 months ago (2016-03-08 23:34:26 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1771313003/ by martiniss@chromium.org.

The reason for reverting is: Reland patch; still need to test..

Powered by Google App Engine
This is Rietveld 408576698