Don't assume the pubspec is only one level up from a library

pkg/docgen/lib/docgen.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// **docgen** is a tool for creating machine readable representations of Dart
 /// code metadata, including: classes, members, comments and annotations.
 ///
 /// docgen is run on a `.dart` file or a directory containing `.dart` files.
 ///
 ///      $ dart docgen.dart [OPTIONS] [FILE/DIR]
@@ skipping 1430 matching lines @@
     var linkResolver = (name) => Indexable.globalFixReference(name);
     var contents = markdown.markdownToHtml(readme
       .readAsStringSync(), linkResolver: linkResolver,
       inlineSyntaxes: _MARKDOWN_SYNTAXES);
     return contents;
   }
 
   /// Given a LibraryMirror that is a library, return the name of the directory
   /// holding that library.
   static String _getRootdir(LibraryMirror mirror) =>
-      path.dirname(path.dirname(mirror.uri.toFilePath()));
+      _packageDirectoryFor(path.dirname(path.dirname(mirror.uri.toFilePath())));

[kevmoo, 2014/02/24 17:49:02]

Could you break this out and explain why there are two nested calls to dirname,
etc?

At the moment, it's not how/why the code is written this way

[Alan Knight, 2014/02/24 18:14:02]

Done.

 
   /// Read a pubspec and return the library name given a [LibraryMirror].
   static String _packageName(LibraryMirror mirror) {
     if (mirror.uri.scheme != 'file') return '';
     var rootdir = _getRootdir(mirror);
     return packageNameFor(rootdir);
   }
 
+  /// Recursively walk up from directory name looking for a pubspec. Return
+  /// the directory that contains it, or null if none is found.
+  static String _packageDirectoryFor(String directoryName) {
+    var dir = directoryName;
+    while (!_pubspecFor(dir).existsSync()) {
+      var newDir = path.dirname(dir);
+      if (newDir == dir) return null;

[kevmoo, 2014/02/24 17:49:02]

What happens in the null case?

[Alan Knight, 2014/02/24 18:14:02]

It should indicate that we're not in a package, so shouldn't try to find package
information. Added some checks so that happens.

+      dir = newDir;
+    }
+    return dir;
+  }
+
+  static File _pubspecFor(String directoryName) =>
+      new File(path.join(directoryName, 'pubspec.yaml'));
+
   /// Read a pubspec and return the library name, given a directory
   static String packageNameFor(String directoryName) {
     var pubspecName = path.join(directoryName, 'pubspec.yaml');
     File pubspec = new File(pubspecName);
     if (!pubspec.existsSync()) return '';
     var contents = pubspec.readAsStringSync();
     var spec = loadYaml(contents);
     return spec["name"];
   }
 
@@ skipping 759 matching lines @@
         .map((e) => originalMirror.getField(e.simpleName).reflectee)
         .where((e) => e != null)
         .toList();
   }
 
   Map toMap() => {
     'name': Indexable.getDocgenObject(mirror, owningLibrary).docName,
     'parameters': parameters
   };
 }