Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1756913003: respect sRGB when converting from sk to gr configs (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
Brian Osman
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/gpu/SkGr.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
reed1
ptal
4 years, 9 months ago (2016-03-03 15:48:51 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756913003/1
4 years, 9 months ago (2016-03-03 15:49:04 UTC) #5
Brian Osman
lgtm
4 years, 9 months ago (2016-03-03 15:52:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756913003/1
4 years, 9 months ago (2016-03-03 15:53:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/c6663dc36b157e40c8225130f5970a346f9ba7c3
4 years, 9 months ago (2016-03-03 16:03:23 UTC) #11
Brian Osman
4 years, 9 months ago (2016-03-03 20:52:38 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1759653005/ by brianosman@google.com.

The reason for reverting is: Two major regressions from this change:
- Mac images may end up too bright, if they're correctly tagged as sRGB. That's
a sub-set of a much larger issue where L32 mode needs to suppress sRGB -> Linear
conversion of pretty much everything.
- Various low-end GPUs (Mali400 Android, iPad4) don't render in sRGB at all,
causing tests to produce no output at all..

Powered by Google App Engine
This is Rietveld 408576698