Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1756903002: debugger: Only bind to the localhost address by default. (Closed)

Created:
4 years, 9 months ago by jcgregorio
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

debugger: Only bind to the localhost address by default. Also add a flag to set the address. Additionally print out the final address the user should visit in their browser. R=joshualitt,ethannicholas BUG=skia: Committed: https://skia.googlesource.com/skia/+/855bd4415c1a26950e946cc2f8756f7e03b61637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/skiaserve/skiaserve.cpp View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jcgregorio
4 years, 9 months ago (2016-03-02 16:37:44 UTC) #3
ethannicholas
On 2016/03/02 16:37:44, jcgregorio wrote: lgtm
4 years, 9 months ago (2016-03-02 16:38:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756903002/1
4 years, 9 months ago (2016-03-02 16:40:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-iOS-Trybot/builds/839) Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 9 months ago (2016-03-02 16:44:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756903002/1
4 years, 9 months ago (2016-03-02 16:56:23 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 17:03:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/855bd4415c1a26950e946cc2f8756f7e03b61637

Powered by Google App Engine
This is Rietveld 408576698