Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: dart/tests/compiler/dart2js/analyze_dart2js_test.dart

Issue 17569004: Implement hashCode on objects stored in a set or used as map keys. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with TOT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/compiler/dart2js/analyze_dart2js_test.dart
diff --git a/dart/tests/compiler/dart2js/analyze_dart2js_test.dart b/dart/tests/compiler/dart2js/analyze_dart2js_test.dart
index a71bd402043d683bc11cbbb9f58481657214fe36..8f2a6419de77fad9afbd867932ed5dcfaf0dd832 100644
--- a/dart/tests/compiler/dart2js/analyze_dart2js_test.dart
+++ b/dart/tests/compiler/dart2js/analyze_dart2js_test.dart
@@ -9,97 +9,17 @@ import '../../../sdk/lib/_internal/compiler/implementation/filenames.dart';
import 'analyze_helper.dart';
/**
- * Map of white-listed warnings and errors.
+ * Map of whitelisted warnings and errors.
*
- * Only add a white-listing together with a bug report to dartbug.com and add
- * the bug issue number as a comment on the white-listing.
+ * Only add a whitelisting together with a bug report to dartbug.com and add
+ * the bug issue number as a comment on the whitelisting.
*
* Use an identifiable suffix of the file uri as key. Use a fixed substring of
- * the error/warning message in the list of white-listings for each file.
+ * the error/warning message in the list of whitelistings for each file.
*/
// TODO(johnniwinther): Support canonical URIs as keys and message kinds as
// values.
const Map<String,List<String>> WHITE_LIST = const {
- 'sdk/lib/_internal/compiler/implementation/constants.dart':
- const [
- 'Hint: The class "PrimitiveConstant" overrides "operator==", '
- 'but not "get hashCode".',
- ],
- 'sdk/lib/_internal/compiler/implementation/dart_types.dart':
- const [
- 'Hint: The class "MalformedType" overrides "operator==", '
- 'but not "get hashCode".',
- 'Hint: The class "InterfaceType" overrides "operator==", '
- 'but not "get hashCode".',
- 'Hint: The class "TypedefType" overrides "operator==", '
- 'but not "get hashCode".',
- ],
-
- 'sdk/lib/_internal/compiler/implementation/ssa/types.dart':
- const [
- 'Hint: The class "HBoundedType" overrides "operator==", '
- 'but not "get hashCode".',
- ],
- 'sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart':
- const [
- 'Hint: The class "IntValue" overrides "operator==", '
- 'but not "get hashCode".',
- 'Hint: The class "InstructionValue" overrides "operator==", '
- 'but not "get hashCode".',
- 'Hint: The class "AddValue" overrides "operator==", '
- 'but not "get hashCode".',
- 'Hint: The class "SubtractValue" overrides "operator==", '
- 'but not "get hashCode".',
- 'Hint: The class "NegateValue" overrides "operator==", '
- 'but not "get hashCode".',
- 'Hint: The class "Range" overrides "operator==", '
- 'but not "get hashCode".',
- ],
- 'sdk/lib/_internal/compiler/implementation/tree/dartstring.dart':
- const [
- 'Hint: The class "DartString" overrides "operator==", '
- 'but not "get hashCode".',
- ],
- 'sdk/lib/_internal/compiler/implementation/types/container_type_mask.dart':
- const [
- 'Hint: The class "ContainerTypeMask" overrides "operator==", '
- 'but not "get hashCode".',
- ],
- 'sdk/lib/_internal/compiler/implementation/types/element_type_mask.dart':
- const [
- 'Hint: The class "ElementTypeMask" overrides "operator==", '
- 'but not "get hashCode".',
- ],
- 'sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart':
- const [
- 'Hint: The class "ArgumentsTypes" overrides "operator==", '
- 'but not "get hashCode".',
- ],
- 'sdk/lib/_internal/compiler/implementation/types/union_type_mask.dart':
- const [
- 'Hint: The class "UnionTypeMask" overrides "operator==", '
- 'but not "get hashCode".',
- ],
- 'sdk/lib/_internal/compiler/implementation/universe/side_effects.dart':
- const [
- 'Hint: The class "SideEffects" overrides "operator==", '
- 'but not "get hashCode".',
- ],
- 'sdk/lib/_internal/compiler/implementation/util/link.dart':
- const [
- 'Hint: The class "Link" overrides "operator==", '
- 'but not "get hashCode".',
- ],
- 'sdk/lib/_internal/compiler/implementation/util/link_implementation.dart':
- const [
- 'Hint: The class "LinkEntry" overrides "operator==", '
- 'but not "get hashCode".',
- ],
- 'sdk/lib/_internal/compiler/implementation/warnings.dart':
- const [
- 'Hint: The class "Message" overrides "operator==", '
- 'but not "get hashCode".',
- ],
};
void main() {

Powered by Google App Engine
This is Rietveld 408576698