Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1756883002: Avoid SetPropertyInternal if the LookupIterator is NotFound (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid SetPropertyInternal if the LookupIterator is NotFound BUG= Committed: https://crrev.com/ca5bd8d4a9d91336d770668dc569661e4fba5aa3 Cr-Commit-Position: refs/heads/master@{#34437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M src/objects.cc View 6 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-02 15:53:02 UTC) #2
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-02 16:02:33 UTC) #3
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-02 16:02:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756883002/1
4 years, 9 months ago (2016-03-02 16:05:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 16:28:02 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 16:28:35 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ca5bd8d4a9d91336d770668dc569661e4fba5aa3
Cr-Commit-Position: refs/heads/master@{#34437}

Powered by Google App Engine
This is Rietveld 408576698