Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4014)

Unified Diff: chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js

Issue 1756853002: Correctly sets the security origin for the IME window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed tests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/ime/ime_window_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js
diff --git a/chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js b/chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js
index 3cb752d05f75c7754e0770e41ae471cb7ffe404e..e3ba1d6ef705d8e9be9ab6a54bcafca377c8e80e 100644
--- a/chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js
+++ b/chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js
@@ -32,6 +32,10 @@ chrome.test.runTests([
chrome.test.assertTrue(!!win);
chrome.test.assertTrue(win instanceof Window);
chrome.test.assertFalse(win.document.webkitHidden);
+ // Test for security origin.
+ // If security origin is not correctly set, there will be securtiy
+ // exceptions when accessing DOM or add event listeners.
+ win.addEventListener('unload', function() {});
chrome.test.succeed();
});
},
@@ -40,7 +44,12 @@ chrome.test.runTests([
chrome.input.ime.createWindow(options, function(win) {
chrome.test.assertNoLastError()
chrome.test.assertTrue(!!win);
+ chrome.test.assertTrue(win instanceof Window);
chrome.test.assertFalse(win.document.webkitHidden);
+ // test for security origin.
+ // If security origin is not correctly set, there will be securtiy
+ // exceptions when accessing DOM or add event listeners.
+ win.addEventListener('unload', function() {});
chrome.test.succeed();
});
}
« no previous file with comments | « chrome/browser/ui/views/ime/ime_window_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698