chrome/browser/ui/views/ime/ime_window_browsertest.cc - Issue 1756853002: Correctly sets the security origin for the IME window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/ime/ime_window_browsertest.cc

Issue 1756853002: Correctly sets the security origin for the IME window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed tests. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/input_method/input_method_engine.cc ('k') | chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/ime/ime_window_browsertest.cc

diff --git a/chrome/browser/ui/views/ime/ime_window_browsertest.cc b/chrome/browser/ui/views/ime/ime_window_browsertest.cc

index 2b8bbf77ba13276fbc2648b6933a98990ff5d9c0..30a95771b18e33bba3cff448887773a980e5f49b 100644

--- a/chrome/browser/ui/views/ime/ime_window_browsertest.cc

+++ b/chrome/browser/ui/views/ime/ime_window_browsertest.cc

@@ -40,7 +40,7 @@ class ImeWindowBrowserTest : public InProcessBrowserTest,

void CreateImeWindow(const gfx::Rect& bounds, bool follow_cursor) {

ime_window_ = new ImeWindow(

- browser()->profile(), nullptr, "about:blank",

+ browser()->profile(), nullptr, nullptr, "about:blank",

follow_cursor ? ImeWindow::FOLLOW_CURSOR : ImeWindow::NORMAL, bounds);

ime_window_->AddObserver(this);

EXPECT_FALSE(ime_window_->ime_native_window()->IsVisible());