Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: chrome/browser/ui/ime/ime_window.h

Issue 1756853002: Correctly sets the security origin for the IME window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed tests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ime/ime_window.h
diff --git a/chrome/browser/ui/ime/ime_window.h b/chrome/browser/ui/ime/ime_window.h
index 77ffd24d2c13d544398ac220a19b78291a6e9324..7faec3263e70f79f56de1b347f3944626fa8087a 100644
--- a/chrome/browser/ui/ime/ime_window.h
+++ b/chrome/browser/ui/ime/ime_window.h
@@ -23,6 +23,7 @@ class GURL;
class Profile;
namespace content {
+class RenderFrameHost;
class WebContents;
}
@@ -58,8 +59,11 @@ class ImeWindow : public content::NotificationObserver,
// Takes |url| as string instead of GURL because resolving GURL requires
// |extension|. As the client code already passes in |extension|, it'd be
// better to simply the client code.
+ // |opener_render_frame_host| is the RenderFrameHost from where the IME window
+ // is opened so that the security origin can be correctly set.
ImeWindow(Profile* profile,
const extensions::Extension* extension,
+ content::RenderFrameHost* opener_render_frame_host,
const std::string& url,
Mode mode,
const gfx::Rect& bounds);
« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc ('k') | chrome/browser/ui/ime/ime_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698