Correctly sets the security origin for the IME window.

Correctly sets the security origin for the IME window.

BUG=517773
Committed: https://crrev.com/80e62dd0b185af05a4050a88bb7bbb463678cd1e
Cr-Commit-Position: refs/heads/master@{#379312}

[Shu Chen, 2016-03-02 15:02:08]

Description was changed from

==========
Correctlyl sets the security origin for the IME window.

BUG=517773
==========

to

==========
Correctly sets the security origin for the IME window.

BUG=517773
==========

[Shu Chen, 2016-03-02 15:13:06]

shuchen@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Shu Chen, 2016-03-02 15:13:07]

Devlin, can you please help to review this cl? Thanks.

[Shu Chen, 2016-03-02 15:13:13]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 15:13:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756853002/20001

[commit-bot: I haz the power, 2016-03-02 15:31:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 15:31:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Shu Chen, 2016-03-02 16:02:50]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 16:03:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756853002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756853002/40001

[commit-bot: I haz the power, 2016-03-02 17:00:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 17:00:53]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Devlin, 2016-03-02 18:05:11]

https://codereview.chromium.org/1756853002/diff/40001/chrome/browser/ui/ime/i...
File chrome/browser/ui/ime/ime_window.h (right):

https://codereview.chromium.org/1756853002/diff/40001/chrome/browser/ui/ime/i...
chrome/browser/ui/ime/ime_window.h:64: content::RenderFrameHost*
render_frame_host,
Document |render_frame_host| - and maybe even rename it to
opener_render_frame_host or something.

https://codereview.chromium.org/1756853002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/ime/ime_window_browsertest.cc (right):

https://codereview.chromium.org/1756853002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/ime/ime_window_browsertest.cc:45:
browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame(),
Does this RFH make sense as the opener?

https://codereview.chromium.org/1756853002/diff/40001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js
(right):

https://codereview.chromium.org/1756853002/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js:36:
function() { console.log('win.onunload'); });
?

[Shu Chen, 2016-03-03 01:33:32]

https://codereview.chromium.org/1756853002/diff/40001/chrome/browser/ui/ime/i...
File chrome/browser/ui/ime/ime_window.h (right):

https://codereview.chromium.org/1756853002/diff/40001/chrome/browser/ui/ime/i...
chrome/browser/ui/ime/ime_window.h:64: content::RenderFrameHost*
render_frame_host,
On 2016/03/02 at 18:05:11, Devlin wrote:
> Document |render_frame_host| - and maybe even rename it to
opener_render_frame_host or something.

Done.

https://codereview.chromium.org/1756853002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/ime/ime_window_browsertest.cc (right):

https://codereview.chromium.org/1756853002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/ime/ime_window_browsertest.cc:45:
browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame(),
On 2016/03/02 at 18:05:11, Devlin wrote:
> Does this RFH make sense as the opener?

Done. I've made it nullptr.

https://codereview.chromium.org/1756853002/diff/40001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js
(right):

https://codereview.chromium.org/1756853002/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js:36:
function() { console.log('win.onunload'); });
On 2016/03/02 at 18:05:11, Devlin wrote:
> ?

The win.addEventListener() is to test the security origin should be correctly
set.
The console.log() was just dummy.

I've removed the console.log().

[Devlin, 2016-03-04 00:07:52]

lgtm

https://codereview.chromium.org/1756853002/diff/80001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js
(right):

https://codereview.chromium.org/1756853002/diff/80001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js:46: //
test for security origin.
Please explain how this tests the security origin.

[Shu Chen, 2016-03-04 11:36:28]

https://codereview.chromium.org/1756853002/diff/80001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js
(right):

https://codereview.chromium.org/1756853002/diff/80001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js:46: //
test for security origin.
On 2016/03/04 00:07:51, Devlin wrote:
> Please explain how this tests the security origin.

Done.

[Shu Chen, 2016-03-04 11:37:53]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2016-03-04 11:37:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1756853002/#ps100001
(title: "addressed comment.")

[commit-bot: I haz the power, 2016-03-04 11:38:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756853002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756853002/100001

[commit-bot: I haz the power, 2016-03-04 12:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 12:36:14]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Shu Chen, 2016-03-04 15:41:05]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2016-03-04 15:41:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1756853002/#ps120001
(title: "fixed tests.")

[commit-bot: I haz the power, 2016-03-04 15:41:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756853002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756853002/120001

[commit-bot: I haz the power, 2016-03-04 17:11:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 17:11:52]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Shu Chen, 2016-03-04 17:18:37]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2016-03-04 17:18:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756853002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756853002/120001

[commit-bot: I haz the power, 2016-03-04 18:17:01]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-04 18:18:10]

Description was changed from

==========
Correctly sets the security origin for the IME window.

BUG=517773
==========

to

==========
Correctly sets the security origin for the IME window.

BUG=517773

Committed: https://crrev.com/80e62dd0b185af05a4050a88bb7bbb463678cd1e
Cr-Commit-Position: refs/heads/master@{#379312}
==========

[commit-bot: I haz the power, 2016-03-04 18:18:11]

Patchset 7 (id:??) landed as
https://crrev.com/80e62dd0b185af05a4050a88bb7bbb463678cd1e
Cr-Commit-Position: refs/heads/master@{#379312}