Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 175683005: android: Remove a few unnecessary md5sum invocations. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 9 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, Tommy Widenflycht, aruslan
Visibility:
Public.

Description

android: Remove a few unnecessary md5sum invocations. When the list of implicit inputs of a build edge shrinks, ninja doesn't rerun it. The Android build uses complex build actions (e.g. ant) whose output depend on directory contents and whatnot, and the Android build by adding "dir/*.java" or similar as implicit inputs. So it's important that ninja does rerun these actions when their list of implicit inputs shrinks. As a workaround, the Android build passes the md5 of the list of implicit inputs as "--ignored" parameter to the build action (ninja does rerun edges whose commandline changes.) Due to copypasta, this --ignored flag is used in a few places where it's not actually used (on edges where all inputs are already passed as regular commandline parameters). Also remove the --ignored parameter from proguard.py as nothing passes it any more. BUG=177552 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M build/android/gyp/proguard.py View 1 chunk +0 lines, -3 lines 0 comments Download
M build/java.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M build/java_prebuilt.gypi View 2 chunks +0 lines, -7 lines 0 comments Download
M build/uiautomator_test.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nico
6 years, 10 months ago (2014-02-22 03:39:18 UTC) #1
cjhopman
lgtm
6 years, 10 months ago (2014-02-24 17:46:02 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-02 18:46:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/175683005/1
6 years, 9 months ago (2014-03-02 18:46:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-02 19:50:54 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=80683
6 years, 9 months ago (2014-03-02 19:50:54 UTC) #6
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-02 20:19:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/175683005/1
6 years, 9 months ago (2014-03-02 20:19:48 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-02 20:22:18 UTC) #9
Message was sent while issue was closed.
Change committed as 254414

Powered by Google App Engine
This is Rietveld 408576698