Issue 175683002: Let gyp_chromium set GYP_CROSSCOMPILE for android and ios.

Issue 175683002: Let gyp_chromium set GYP_CROSSCOMPILE for android and ios. (Closed)

Created:
6 years, 10 months ago by Nico

Modified:
6 years, 10 months ago

Reviewers:
justincohen, scottmg

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, iannucci, stuartmorgan, justincohen, sdefresne

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Let gyp_chromium set GYP_CROSSCOMPILE for android and ios. Then envsetup doesn't need to set it, and the chromium.gyp_env files used in the ios build no longer has to set this either. BUG=330631 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252649

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 6

Patch Set 4 : comments #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -40 lines)			Patch
	M	build/android/envsetup.sh	View	1 2 3	1 chunk	+1 line, -6 lines	0 comments	Download
	M	build/gyp_chromium	View	1 2 3	6 chunks	+44 lines, -34 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

https://codereview.chromium.org/175683002/diff/50001/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/175683002/diff/50001/build/gyp_chromium#newcode125 build/gyp_chromium:125: supplemental_files += [include_gypi] (This block was moved here unmodified ...

6 years, 10 months ago (2014-02-21 20:32:30 UTC) #1

justincohen

Awesome, thanks nico! https://codereview.chromium.org/175683002/diff/50001/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/175683002/diff/50001/build/gyp_chromium#newcode489 build/gyp_chromium:489: 'GYP_CROSSCOMPILE' not in os.environ)): Just curious, ...

6 years, 10 months ago (2014-02-21 20:49:34 UTC) #2

scottmg

lgtm https://codereview.chromium.org/175683002/diff/50001/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/175683002/diff/50001/build/gyp_chromium#newcode156 build/gyp_chromium:156: # It's not possible to let set a ...

6 years, 10 months ago (2014-02-21 20:50:29 UTC) #3

Nico

Thanks! https://codereview.chromium.org/175683002/diff/50001/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/175683002/diff/50001/build/gyp_chromium#newcode156 build/gyp_chromium:156: # It's not possible to let set a ...

6 years, 10 months ago (2014-02-21 21:00:59 UTC) #4

Nico

6 years, 10 months ago (2014-02-21 21:27:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r252649 (presubmit successful).

Expand Messages | Collapse Messages