Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 17568015: New array bounds check elimination pass (focused on induction variables and bitwise operations). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed review comments. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/bounds-check-elimination.cc » ('j') | src/bounds-check-elimination.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4308 matching lines...) Expand 10 before | Expand all | Expand 10 after
4319 ToInteger32(LConstantOperand::cast(instr->index())); 4319 ToInteger32(LConstantOperand::cast(instr->index()));
4320 if (instr->hydrogen()->length()->representation().IsSmi()) { 4320 if (instr->hydrogen()->length()->representation().IsSmi()) {
4321 __ mov(ip, Operand(Smi::FromInt(constant_index))); 4321 __ mov(ip, Operand(Smi::FromInt(constant_index)));
4322 } else { 4322 } else {
4323 __ mov(ip, Operand(constant_index)); 4323 __ mov(ip, Operand(constant_index));
4324 } 4324 }
4325 __ cmp(ip, ToRegister(instr->length())); 4325 __ cmp(ip, ToRegister(instr->length()));
4326 } else { 4326 } else {
4327 __ cmp(ToRegister(instr->index()), ToRegister(instr->length())); 4327 __ cmp(ToRegister(instr->index()), ToRegister(instr->length()));
4328 } 4328 }
4329 DeoptimizeIf(hs, instr->environment()); 4329 Condition condition = instr->hydrogen()->allow_equality() ? hi : hs;
4330 DeoptimizeIf(condition, instr->environment());
4330 } 4331 }
4331 4332
4332 4333
4333 void LCodeGen::DoStoreKeyedExternalArray(LStoreKeyed* instr) { 4334 void LCodeGen::DoStoreKeyedExternalArray(LStoreKeyed* instr) {
4334 Register external_pointer = ToRegister(instr->elements()); 4335 Register external_pointer = ToRegister(instr->elements());
4335 Register key = no_reg; 4336 Register key = no_reg;
4336 ElementsKind elements_kind = instr->elements_kind(); 4337 ElementsKind elements_kind = instr->elements_kind();
4337 bool key_is_constant = instr->key()->IsConstantOperand(); 4338 bool key_is_constant = instr->key()->IsConstantOperand();
4338 int constant_key = 0; 4339 int constant_key = 0;
4339 if (key_is_constant) { 4340 if (key_is_constant) {
(...skipping 1540 matching lines...) Expand 10 before | Expand all | Expand 10 after
5880 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5881 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5881 __ ldr(result, FieldMemOperand(scratch, 5882 __ ldr(result, FieldMemOperand(scratch,
5882 FixedArray::kHeaderSize - kPointerSize)); 5883 FixedArray::kHeaderSize - kPointerSize));
5883 __ bind(&done); 5884 __ bind(&done);
5884 } 5885 }
5885 5886
5886 5887
5887 #undef __ 5888 #undef __
5888 5889
5889 } } // namespace v8::internal 5890 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/bounds-check-elimination.cc » ('j') | src/bounds-check-elimination.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698