Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 17568014: Remove redundant calls to obtain WebView in PrintWebViewHelper::GetPrintFrame() (Closed)

Created:
7 years, 6 months ago by vivekg_samsung
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Vitaly Buka (NO REVIEWS)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove redundant calls to obtain WebView in PrintWebViewHelper::GetPrintFrame() Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208440

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/renderer/printing/print_web_view_helper.cc View 1 chunk +5 lines, -5 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
vivekg_samsung
https://codereview.chromium.org/17568014/diff/1/chrome/renderer/printing/print_web_view_helper.cc File chrome/renderer/printing/print_web_view_helper.cc (right): https://codereview.chromium.org/17568014/diff/1/chrome/renderer/printing/print_web_view_helper.cc#newcode863 chrome/renderer/printing/print_web_view_helper.cc:863: if (!webView) Having both "DCHECK(webView)" and "if (!webView) return ...
7 years, 6 months ago (2013-06-24 09:29:14 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-06-24 12:48:31 UTC) #2
vandebo (ex-Chrome)
LGTM
7 years, 6 months ago (2013-06-24 14:38:05 UTC) #3
vivekg_samsung
On 2013/06/24 14:38:05, vandebo wrote: > LGTM Thank you.
7 years, 6 months ago (2013-06-24 16:06:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/17568014/1
7 years, 6 months ago (2013-06-24 16:07:16 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=11783
7 years, 6 months ago (2013-06-24 16:20:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/17568014/1
7 years, 6 months ago (2013-06-24 17:27:47 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=11798
7 years, 6 months ago (2013-06-24 17:38:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/17568014/1
7 years, 6 months ago (2013-06-25 04:55:23 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-25 06:40:11 UTC) #10
Message was sent while issue was closed.
Change committed as 208440

Powered by Google App Engine
This is Rietveld 408576698