Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 1756793002: [compiler] Introduce proper StrictNotEqualStub. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Introduce proper StrictNotEqualStub. Generalize the code that we have for StrictEqualStub to also general a StrictNotEqualStub and hook that up with TurboFan and Ignition. It's still falling back to the runtime for every String (in)equality check. R=yangguo@chromium.org Committed: https://crrev.com/ca6d0b1eb17711d051b4bbb3923b16ce46842c7d Cr-Commit-Position: refs/heads/master@{#34426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -33 lines) Patch
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 10 chunks +48 lines, -27 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-02 12:12:58 UTC) #1
Benedikt Meurer
Hey Yang, Here's a simple generalization to cover StrictNotEqual as well. Please take a look. ...
4 years, 9 months ago (2016-03-02 12:13:32 UTC) #2
Yang
On 2016/03/02 12:13:32, Benedikt Meurer wrote: > Hey Yang, > > Here's a simple generalization ...
4 years, 9 months ago (2016-03-02 12:20:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756793002/1
4 years, 9 months ago (2016-03-02 12:21:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 12:34:41 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 12:36:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca6d0b1eb17711d051b4bbb3923b16ce46842c7d
Cr-Commit-Position: refs/heads/master@{#34426}

Powered by Google App Engine
This is Rietveld 408576698