third_party/WebKit/Source/core/style/StyleInvalidImage.h - Issue 1756763004: Merge image sizing algorithms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleInvalidImage.h

Issue 1756763004: Merge image sizing algorithms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Extend test to cover svg and non-svg case Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/StyleInvalidImage.h

diff --git a/third_party/WebKit/Source/core/style/StyleInvalidImage.h b/third_party/WebKit/Source/core/style/StyleInvalidImage.h

index d10040225a538a59de60be5d7fb155f4e6e62ab1..79e7899398ef39f94b4686e036b5abcd16de51ea 100644

--- a/third_party/WebKit/Source/core/style/StyleInvalidImage.h

+++ b/third_party/WebKit/Source/core/style/StyleInvalidImage.h

@@ -23,7 +23,7 @@ public:

PassRefPtrWillBeRawPtr<CSSValue> computedCSSValue() const override { return cssValue(); }

- LayoutSize imageSize(const LayoutObject*, float /*multiplier*/) const override { return LayoutSize(); }

+ LayoutSize imageSize(const LayoutObject*, float /*multiplier*/, const LayoutSize& /*defaultObjectSize*/) const override { return LayoutSize(); }

bool imageHasRelativeSize() const override { return false; }

void computeIntrinsicDimensions(const LayoutObject*, FloatSize& /* intrinsicSize */, FloatSize& /* intrinsicRatio */) override { }

bool usesImageContainerSize() const override { return false; }