Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/core/style/StyleFetchedImage.cpp

Issue 1756763004: Merge image sizing algorithms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unused variable 'styleImage' in release Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 bool StyleFetchedImage::isLoaded() const 84 bool StyleFetchedImage::isLoaded() const
85 { 85 {
86 return m_image->isLoaded(); 86 return m_image->isLoaded();
87 } 87 }
88 88
89 bool StyleFetchedImage::errorOccurred() const 89 bool StyleFetchedImage::errorOccurred() const
90 { 90 {
91 return m_image->errorOccurred(); 91 return m_image->errorOccurred();
92 } 92 }
93 93
94 LayoutSize StyleFetchedImage::imageSize(const LayoutObject* layoutObject, float multiplier) const 94 LayoutSize StyleFetchedImage::imageSize(const LayoutObject* layoutObject, float multiplier, const LayoutSize& defaultObjectSize) const
95 { 95 {
96 return m_image->imageSize(LayoutObject::shouldRespectImageOrientation(layout Object), multiplier); 96 if (m_image->image() && m_image->image()->isSVGImage())
97 return imageSizeForSVGImage(toSVGImage(m_image->image()), multiplier, de faultObjectSize);
98
99 // Image orientation should only be respected for content images,
100 // not decorative images such as StyleImage (backgrounds,
101 // border-image, etc.)
102 //
103 // https://drafts.csswg.org/css-images-3/#the-image-orientation
104 return m_image->imageSize(DoNotRespectImageOrientation, multiplier);
97 } 105 }
98 106
99 bool StyleFetchedImage::imageHasRelativeSize() const 107 bool StyleFetchedImage::imageHasRelativeSize() const
100 { 108 {
101 return m_image->imageHasRelativeSize(); 109 return m_image->imageHasRelativeSize();
102 } 110 }
103 111
104 void StyleFetchedImage::computeIntrinsicDimensions(const LayoutObject*, FloatSiz e& intrinsicSize, FloatSize& intrinsicRatio) 112 void StyleFetchedImage::computeIntrinsicDimensions(const LayoutObject*, FloatSiz e& intrinsicSize, FloatSize& intrinsicRatio)
105 { 113 {
106 m_image->computeIntrinsicDimensions(intrinsicSize, intrinsicRatio); 114 m_image->computeIntrinsicDimensions(intrinsicSize, intrinsicRatio);
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 } 152 }
145 153
146 DEFINE_TRACE(StyleFetchedImage) 154 DEFINE_TRACE(StyleFetchedImage)
147 { 155 {
148 visitor->trace(m_image); 156 visitor->trace(m_image);
149 visitor->trace(m_document); 157 visitor->trace(m_document);
150 StyleImage::trace(visitor); 158 StyleImage::trace(visitor);
151 } 159 }
152 160
153 } // namespace blink 161 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/StyleFetchedImage.h ('k') | third_party/WebKit/Source/core/style/StyleFetchedImageSet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698