Merge image sizing algorithms

third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 28 matching lines @@
 PassRefPtrWillBeRawPtr<CSSValue> StyleGeneratedImage::cssValue() const
 {
     return m_imageGeneratorValue.get();
 }
 
 PassRefPtrWillBeRawPtr<CSSValue> StyleGeneratedImage::computedCSSValue() const
 {
     return m_imageGeneratorValue->valueWithURLsMadeAbsolute();
 }
 
-LayoutSize StyleGeneratedImage::imageSize(const LayoutObject* layoutObject, float multiplier) const
+LayoutSize StyleGeneratedImage::imageSize(const LayoutObject* layoutObject, float multiplier, const LayoutSize& defaultObjectSize) const
 {
     if (m_fixedSize) {
-        LayoutSize fixedSize(m_imageGeneratorValue->fixedSize(layoutObject));
+        FloatSize unzoomedDefaultObjectSize(defaultObjectSize);

[fs, 2016/03/04 09:00:56]

(Strange as it may sound/feel, but this looks like it could use the code in the
new helper too =))

[davve, 2016/03/04 13:02:56]

I'm not sure what you refer to by 'this' here but I dialed up the code sharing a
notch by sharing at least the zooming code.

[fs, 2016/03/04 13:06:56]

Yes, that was the 'this' I was referring too ("this method"). Even nicer!

+        unzoomedDefaultObjectSize.scale(1 / multiplier);
+        LayoutSize fixedSize(m_imageGeneratorValue->fixedSize(layoutObject, unzoomedDefaultObjectSize));
         if (multiplier == 1.0f)
             return fixedSize;
 
         LayoutUnit width(fixedSize.width() * multiplier);
         LayoutUnit height(fixedSize.height() * multiplier);
 
         // Don't let images that have a width/height >= 1 shrink below 1 when zoomed.
         if (fixedSize.width() > LayoutUnit())
             width = max(LayoutUnit(1), width);
 
         if (fixedSize.height() > LayoutUnit())
             height = max(LayoutUnit(1), height);
 
         return LayoutSize(width, height);
     }
 
-    return LayoutSize();
+    return defaultObjectSize;
 }
 
 void StyleGeneratedImage::computeIntrinsicDimensions(const LayoutObject* layoutObject, FloatSize& intrinsicSize, FloatSize& intrinsicRatio)
 {
     // At a zoom level of 1 the image is guaranteed to have an integer size.
-    LayoutSize size = imageSize(layoutObject, 1);
+    LayoutSize size = imageSize(layoutObject, 1, LayoutSize());
     ASSERT(size.fraction().isZero());
     intrinsicSize = intrinsicRatio = FloatSize(size);
 }
 
 void StyleGeneratedImage::addClient(LayoutObject* layoutObject)
 {
     m_imageGeneratorValue->addClient(layoutObject, IntSize());
 }
 
 void StyleGeneratedImage::removeClient(LayoutObject* layoutObject)
@@ skipping 11 matching lines @@
     return m_imageGeneratorValue->knownToBeOpaque(layoutObject);
 }
 
 DEFINE_TRACE(StyleGeneratedImage)
 {
     visitor->trace(m_imageGeneratorValue);
     StyleImage::trace(visitor);
 }
 
 } // namespace blink