X87: [Interpreter] Fixes PushArgsAndConstruct builtin to not store any data outside esp.

X87: [Interpreter] Fixes PushArgsAndConstruct builtin to not store any data outside esp.

  port dbf5fffd2d58289fcb05c0ac7dde40c76dfa9472 (r34397)

  original commit message:
  In ia32 PushArgsAndConstruct builtin, we run out of registers and need to
  temporarily store the data in the stack. In the earlier implementation,
  a location outside the esp was used. This causes a problem if there is a
  interrupt/signals which would use the same stack and corrupt the data that
  is above the esp. This cl fixes it by pushing it onto the stack so that
  the stack pointer is updated and hence the corruption will not happen. We
  reuse the slot meant for receiver as a temporary store.

BUG=

Committed: https://crrev.com/11162a48d342dff499801d16393f0dfbb3d4fb39
Cr-Commit-Position: refs/heads/master@{#34420}

[zhengxing.li, 2016-03-02 07:57:30]

zhengxing.li@intel.com changed reviewers:
+ chunyang.dai@intel.com, mythria@chromium.org, weiliang.lin@intel.com

[zhengxing.li, 2016-03-02 07:57:31]

PTAL, thanks!

[Weiliang, 2016-03-02 08:21:30]

lgtm

[zhengxing.li, 2016-03-02 08:25:07]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-03-02 08:25:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756743002/1

[commit-bot: I haz the power, 2016-03-02 08:45:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-02 08:46:46]

Description was changed from

==========
X87: [Interpreter] Fixes PushArgsAndConstruct builtin to not store any data
outside esp.

  port dbf5fffd2d58289fcb05c0ac7dde40c76dfa9472 (r34397)

  original commit message:
  In ia32 PushArgsAndConstruct builtin, we run out of registers and need to
  temporarily store the data in the stack. In the earlier implementation,
  a location outside the esp was used. This causes a problem if there is a
  interrupt/signals which would use the same stack and corrupt the data that
  is above the esp. This cl fixes it by pushing it onto the stack so that
  the stack pointer is updated and hence the corruption will not happen. We
  reuse the slot meant for receiver as a temporary store.

BUG=
==========

to

==========
X87: [Interpreter] Fixes PushArgsAndConstruct builtin to not store any data
outside esp.

  port dbf5fffd2d58289fcb05c0ac7dde40c76dfa9472 (r34397)

  original commit message:
  In ia32 PushArgsAndConstruct builtin, we run out of registers and need to
  temporarily store the data in the stack. In the earlier implementation,
  a location outside the esp was used. This causes a problem if there is a
  interrupt/signals which would use the same stack and corrupt the data that
  is above the esp. This cl fixes it by pushing it onto the stack so that
  the stack pointer is updated and hence the corruption will not happen. We
  reuse the slot meant for receiver as a temporary store.

BUG=

Committed: https://crrev.com/11162a48d342dff499801d16393f0dfbb3d4fb39
Cr-Commit-Position: refs/heads/master@{#34420}
==========

[commit-bot: I haz the power, 2016-03-02 08:46:48]

Patchset 1 (id:??) landed as
https://crrev.com/11162a48d342dff499801d16393f0dfbb3d4fb39
Cr-Commit-Position: refs/heads/master@{#34420}

[mythria, 2016-03-02 11:35:53]

Thanks for fixing this.