Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/base/pipeline_unittest.cc

Issue 17567007: Made MessagePump a non-thread safe class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/message_loop/message_loop_proxy_impl.h ('K') | « chrome/browser/ui/cocoa/run_loop_testing.mm ('k') | net/dns/dns_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_unittest.cc
diff --git a/media/base/pipeline_unittest.cc b/media/base/pipeline_unittest.cc
index a121ee476911d08e097838024e4daa7f0a340b2d..8db22cdf40bbc88b3d4ee2ef3c82e7c10131054a 100644
--- a/media/base/pipeline_unittest.cc
+++ b/media/base/pipeline_unittest.cc
@@ -689,14 +689,14 @@ static void TestNoCallsAfterError(
CHECK(message_loop);
// When we get to this stage, the message loop should be empty.
- message_loop->AssertIdle();
+ EXPECT_TRUE(message_loop->IsIdleForTest());
// Make calls on pipeline after error has occurred.
pipeline->SetPlaybackRate(0.5f);
pipeline->SetVolume(0.5f);
// No additional tasks should be queued as a result of these calls.
- message_loop->AssertIdle();
+ EXPECT_TRUE(message_loop->IsIdleForTest());
}
TEST_F(PipelineTest, NoMessageDuringTearDownFromError) {
« base/message_loop/message_loop_proxy_impl.h ('K') | « chrome/browser/ui/cocoa/run_loop_testing.mm ('k') | net/dns/dns_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698