base/message_loop/message_pump_mac.mm - Issue 17567007: Made MessagePump a non-thread safe class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/message_loop/message_pump_mac.mm

Issue 17567007: Made MessagePump a non-thread safe class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CR feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/message_loop/message_pump_mac.mm

diff --git a/base/message_loop/message_pump_mac.mm b/base/message_loop/message_pump_mac.mm

index 957d3e9e78da932fa72b3d4892c23b0a807d77f8..17e29b14953b7bd40e40eca012cc618b1101b580 100644

--- a/base/message_loop/message_pump_mac.mm

+++ b/base/message_loop/message_pump_mac.mm

@@ -616,6 +616,9 @@ void MessagePumpNSApplication::Quit() {

MessagePumpCrApplication::MessagePumpCrApplication() {

}

+MessagePumpCrApplication::~MessagePumpCrApplication() {

// Prevents an autorelease pool from being created if the app is in the midst of

// handling a UI event because various parts of AppKit depend on objects that

// are created while handling a UI event to be autoreleased in the event loop.