net/dns/dns_transaction_unittest.cc - Issue 17567007: Made MessagePump a non-thread safe class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_transaction_unittest.cc

Issue 17567007: Made MessagePump a non-thread safe class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved incoming_queue_ to MessageLoopProxyImpl Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/dns_transaction_unittest.cc

diff --git a/net/dns/dns_transaction_unittest.cc b/net/dns/dns_transaction_unittest.cc

index ee790057c24d32dd8026d92a72fd59ac32788098..ea2ca3fe30509cd5dfdfa70d24a77bbc030bcfe2 100644

--- a/net/dns/dns_transaction_unittest.cc

+++ b/net/dns/dns_transaction_unittest.cc

@@ -626,7 +626,7 @@ TEST_F(DnsTransactionTest, Timeout) {

TransactionHelper helper0(kT0HostName, kT0Qtype, ERR_DNS_TIMED_OUT);

EXPECT_TRUE(helper0.RunUntilDone(transaction_factory_.get()));

- base::MessageLoop::current()->AssertIdle();

+ EXPECT_TRUE(base::MessageLoop::current()->IsIdleForTest());

}

TEST_F(DnsTransactionTest, ServerFallbackAndRotate) {