Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1756693003: Allow negation of doubles in asm typer. (Closed)

Created:
4 years, 9 months ago by bradnelson
Modified:
4 years, 9 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow negation of doubles in asm typer. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/c6abc94f8ffc9966bd27306b47af44fa3589a0ca Cr-Commit-Position: refs/heads/master@{#34449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M src/typing-asm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bradnelson
4 years, 9 months ago (2016-03-02 22:45:53 UTC) #1
aseemgarg
lgtm
4 years, 9 months ago (2016-03-02 23:08:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756693003/1
4 years, 9 months ago (2016-03-02 23:40:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 23:43:38 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 23:45:26 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c6abc94f8ffc9966bd27306b47af44fa3589a0ca
Cr-Commit-Position: refs/heads/master@{#34449}

Powered by Google App Engine
This is Rietveld 408576698