Instantiate interface types to bounds.

Instantiate interface types to bounds.

Refactors some common code into TypeSystem, and makes strong mode
interface types instantiate to bounds when no type arguments are
passed.

Fixes https://github.com/dart-lang/sdk/issues/25877 .

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/ce806bf30770bb447d077dd5e396b3a6b1906f51

[Leaf, 2016-03-02 02:20:02]

leafp@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2016-03-02 17:04:07]

lgtm

https://codereview.chromium.org/1756673002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/type_system.dart (right):

https://codereview.chromium.org/1756673002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:485: return
type.substitute4(typeArguments);
another thought here: rename this to "instantiate" (leaving substitute4 as
@deprecated forwarding to the new API). Then `typeSystem.instantiateType(type,
args)` becomes `type.instantiate(args)`

(related to: https://github.com/dart-lang/sdk/issues/25378)

https://codereview.chromium.org/1756673002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:524: return type.typeParameters;
This is another one that could be fixed as part of
https://github.com/dart-lang/sdk/issues/25378, by introducing `typeFormals` on
InterfaceType.

https://codereview.chromium.org/1756673002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:541: return type.typeArguments;
this entire method could be just:

    TypeParameterTypeImpl.getTypes(typeFormalsAsElements(type))

(`type.typeArguments` is faster ... but it's only correct if the type hasn't
been instantiated. I think once we fix
https://github.com/dart-lang/sdk/issues/25378 it won't make sense to use
typeArguments.)

[Leaf, 2016-03-02 20:03:56]

https://codereview.chromium.org/1756673002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/type_system.dart (right):

https://codereview.chromium.org/1756673002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:485: return
type.substitute4(typeArguments);
On 2016/03/02 17:04:07, John Messerly wrote:
> another thought here: rename this to "instantiate" (leaving substitute4 as
> @deprecated forwarding to the new API). Then `typeSystem.instantiateType(type,
> args)` becomes `type.instantiate(args)`
> 
> (related to: https://github.com/dart-lang/sdk/issues/25378)

I'll follow up with a CL to do this.

https://codereview.chromium.org/1756673002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:524: return type.typeParameters;
On 2016/03/02 17:04:07, John Messerly wrote:
> This is another one that could be fixed as part of
> https://github.com/dart-lang/sdk/issues/25378, by introducing `typeFormals` on
> InterfaceType.

Yes, thought about it.  I'll consider doing this in a followup, but may push it
off - I don't want to rathole right now.

https://codereview.chromium.org/1756673002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:541: return type.typeArguments;
On 2016/03/02 17:04:07, John Messerly wrote:
> this entire method could be just:
> 
>     TypeParameterTypeImpl.getTypes(typeFormalsAsElements(type))
> 
> (`type.typeArguments` is faster ... but it's only correct if the type hasn't
> been instantiated. I think once we fix
> https://github.com/dart-lang/sdk/issues/25378 it won't make sense to use
> typeArguments.)

Done.

[Leaf, 2016-03-02 21:18:21]

Description was changed from

==========
Instantiate interface types to bounds.

Refactors some common code into TypeSystem, and makes strong mode
interface types instantiate to bounds when no type arguments are
passed.

Fixes https://github.com/dart-lang/sdk/issues/25877 .

BUG=
==========

to

==========
Instantiate interface types to bounds.

Refactors some common code into TypeSystem, and makes strong mode
interface types instantiate to bounds when no type arguments are
passed.

Fixes https://github.com/dart-lang/sdk/issues/25877 .

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ce806bf30770bb447d077dd5e396b3a6b1906f51
==========

[Leaf, 2016-03-02 21:18:23]

Committed patchset #4 (id:60001) manually as
ce806bf30770bb447d077dd5e396b3a6b1906f51 (presubmit successful).