Defer WebGL lost context restore until visible.

Defer WebGL lost context restore until visible.

This doesn't affect the force-evict logic but only contexts
in 'Auto' recovery mode. If the context is lost while hidden,
defer restoring it until the canvas becomes visible again.

The motivation is that this is more efficient wrt memory,
and in particular on Android avoids webgl context restore
to fight with the GPU oom killer for hidden webgl tabs.

BUG=586905
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/2292849b75d884faff3d77c37b4fcf9743e13388
Cr-Commit-Position: refs/heads/master@{#380293}

[no sievers, 2016-03-01 22:52:28]

Description was changed from

==========
Defer WebGL lost context restore until visible.

This doesn't affect the force-evict logic but only contexts
in 'Auto' recovery mode. If the context is lost while hidden,
defer restoring it until the canvas becomes visible again.

The motivation is that this is more efficient wrt memory,
and in particular on Android avoids webgl context restore
to fight with the GPU oom killer for hidden webgl tabs.

BUG=586905
==========

to

==========
Defer WebGL lost context restore until visible.

This doesn't affect the force-evict logic but only contexts
in 'Auto' recovery mode. If the context is lost while hidden,
defer restoring it until the canvas becomes visible again.

The motivation is that this is more efficient wrt memory,
and in particular on Android avoids webgl context restore
to fight with the GPU oom killer for hidden webgl tabs.

BUG=586905
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[no sievers, 2016-03-01 22:53:08]

Description was changed from

==========
Defer WebGL lost context restore until visible.

This doesn't affect the force-evict logic but only contexts
in 'Auto' recovery mode. If the context is lost while hidden,
defer restoring it until the canvas becomes visible again.

The motivation is that this is more efficient wrt memory,
and in particular on Android avoids webgl context restore
to fight with the GPU oom killer for hidden webgl tabs.

BUG=586905
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Defer WebGL lost context restore until visible.

This doesn't affect the force-evict logic but only contexts
in 'Auto' recovery mode. If the context is lost while hidden,
defer restoring it until the canvas becomes visible again.

The motivation is that this is more efficient wrt memory,
and in particular on Android avoids webgl context restore
to fight with the GPU oom killer for hidden webgl tabs.

BUG=586905
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[no sievers, 2016-03-01 22:53:08]

sievers@chromium.org changed reviewers:
+ bajones@chromium.org, kbr@chromium.org

[no sievers, 2016-03-01 22:53:14]

ptal

[Ken Russell (switch to Gerrit), 2016-03-02 01:23:07]

kbr@chromium.org changed reviewers:
+ zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-03-02 01:23:07]

Thanks, this is a clever fix and lgtm if it's been tested.

We should consider adding a test to
src/content/test/gpu/gpu_tests/context_lost.py to verify the new behavior.

[no sievers, 2016-03-10 00:01:19]

The CQ bit was checked by sievers@chromium.org

[no sievers, 2016-03-10 00:01:19]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1756633002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-10 00:02:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756633002/20001

[no sievers, 2016-03-10 00:03:41]

On 2016/03/02 01:23:07, Ken Russell wrote:
> Thanks, this is a clever fix and lgtm if it's been tested.
> 
> We should consider adding a test to
> src/content/test/gpu/gpu_tests/context_lost.py to verify the new behavior.

Ok, let me try land this as I'm having some issues making a nonflaky test for
this.

First of all it needs to go through the about:gpucrash path (vs. the extension)
since my patch intentionally only changes the behavior for real context losses.
And then I need to test that it does *not* restore the context when hidden which
needs either a timeout to convince ourselves, or to do an extra roundtrip to the
automation controller (was lost now triggers make visible), but even then I'm
not sure that this is not racy the way it's dispatched.

[Ken Russell (switch to Gerrit), 2016-03-10 01:34:14]

On 2016/03/10 00:03:41, sievers wrote:
> On 2016/03/02 01:23:07, Ken Russell wrote:
> > Thanks, this is a clever fix and lgtm if it's been tested.
> > 
> > We should consider adding a test to
> > src/content/test/gpu/gpu_tests/context_lost.py to verify the new behavior.
> 
> Ok, let me try land this as I'm having some issues making a nonflaky test for
> this.
> 
> First of all it needs to go through the about:gpucrash path (vs. the
extension)
> since my patch intentionally only changes the behavior for real context
losses.
> And then I need to test that it does *not* restore the context when hidden
which
> needs either a timeout to convince ourselves, or to do an extra roundtrip to
the
> automation controller (was lost now triggers make visible), but even then I'm
> not sure that this is not racy the way it's dispatched.

No problem. We may still be able to modify the context_lost test to verify both
of these. We could also change the WEBGL_lose_context extension to use the
GL_CHROMIUM_lose_context extension under the hood.

[commit-bot: I haz the power, 2016-03-10 01:39:11]

Description was changed from

==========
Defer WebGL lost context restore until visible.

This doesn't affect the force-evict logic but only contexts
in 'Auto' recovery mode. If the context is lost while hidden,
defer restoring it until the canvas becomes visible again.

The motivation is that this is more efficient wrt memory,
and in particular on Android avoids webgl context restore
to fight with the GPU oom killer for hidden webgl tabs.

BUG=586905
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Defer WebGL lost context restore until visible.

This doesn't affect the force-evict logic but only contexts
in 'Auto' recovery mode. If the context is lost while hidden,
defer restoring it until the canvas becomes visible again.

The motivation is that this is more efficient wrt memory,
and in particular on Android avoids webgl context restore
to fight with the GPU oom killer for hidden webgl tabs.

BUG=586905
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-10 01:39:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-10 01:40:33]

Description was changed from

==========
Defer WebGL lost context restore until visible.

This doesn't affect the force-evict logic but only contexts
in 'Auto' recovery mode. If the context is lost while hidden,
defer restoring it until the canvas becomes visible again.

The motivation is that this is more efficient wrt memory,
and in particular on Android avoids webgl context restore
to fight with the GPU oom killer for hidden webgl tabs.

BUG=586905
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Defer WebGL lost context restore until visible.

This doesn't affect the force-evict logic but only contexts
in 'Auto' recovery mode. If the context is lost while hidden,
defer restoring it until the canvas becomes visible again.

The motivation is that this is more efficient wrt memory,
and in particular on Android avoids webgl context restore
to fight with the GPU oom killer for hidden webgl tabs.

BUG=586905
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/2292849b75d884faff3d77c37b4fcf9743e13388
Cr-Commit-Position: refs/heads/master@{#380293}
==========

[commit-bot: I haz the power, 2016-03-10 01:40:34]

Patchset 2 (id:??) landed as
https://crrev.com/2292849b75d884faff3d77c37b4fcf9743e13388
Cr-Commit-Position: refs/heads/master@{#380293}