Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1756623002: Add console API to worklets. (Closed)

Created:
4 years, 9 months ago by ikilpatrick
Modified:
4 years, 9 months ago
Reviewers:
kinuko, philipj_slow
CC:
chromium-reviews, blink-reviews, kinuko+worker_chromium.org, falken, blink-worker-reviews_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add console API to worklets. This is specifically for main thread worklets, as directly adds messages to the parent frame's console. BUG=567358 Committed: https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4 Cr-Commit-Position: refs/heads/master@{#379645}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : rebase #

Patch Set 5 : . #

Total comments: 5

Patch Set 6 : update comments. #

Total comments: 1

Patch Set 7 : add CORE_EXPORT to ConsoleBase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -29 lines) Patch
M third_party/WebKit/Source/core/frame/Console.idl View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ConsoleBase.h View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ConsoleBase.idl View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Window.idl View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerConsole.idl View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/DOMWindowWorklet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/worklet/Worklet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/Worklet.cpp View 1 1 chunk +5 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/modules/worklet/WorkletConsole.h View 1 2 3 4 5 6 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/worklet/WorkletConsole.cpp View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/worklet/WorkletConsole.idl View 1 2 3 4 5 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h View 1 2 6 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp View 1 2 4 chunks +36 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
ikilpatrick
4 years, 9 months ago (2016-03-04 03:26:49 UTC) #2
kinuko
lgtm https://codereview.chromium.org/1756623002/diff/80001/third_party/WebKit/Source/modules/worklet/WorkletConsole.idl File third_party/WebKit/Source/modules/worklet/WorkletConsole.idl (right): https://codereview.chromium.org/1756623002/diff/80001/third_party/WebKit/Source/modules/worklet/WorkletConsole.idl#newcode7 third_party/WebKit/Source/modules/worklet/WorkletConsole.idl:7: nit: Looks like most of IDL files that ...
4 years, 9 months ago (2016-03-04 08:56:58 UTC) #3
kinuko
On 2016/03/04 08:56:58, kinuko wrote: > lgtm > > https://codereview.chromium.org/1756623002/diff/80001/third_party/WebKit/Source/modules/worklet/WorkletConsole.idl > File third_party/WebKit/Source/modules/worklet/WorkletConsole.idl (right): > ...
4 years, 9 months ago (2016-03-04 10:48:53 UTC) #6
philipj_slow
https://codereview.chromium.org/1756623002/diff/80001/third_party/WebKit/Source/modules/worklet/WorkletConsole.idl File third_party/WebKit/Source/modules/worklet/WorkletConsole.idl (right): https://codereview.chromium.org/1756623002/diff/80001/third_party/WebKit/Source/modules/worklet/WorkletConsole.idl#newcode6 third_party/WebKit/Source/modules/worklet/WorkletConsole.idl:6: // https://developer.chrome.com/devtools/docs/console-api It would be nice if you could ...
4 years, 9 months ago (2016-03-04 11:02:05 UTC) #7
ikilpatrick
https://codereview.chromium.org/1756623002/diff/80001/third_party/WebKit/Source/modules/worklet/WorkletConsole.idl File third_party/WebKit/Source/modules/worklet/WorkletConsole.idl (right): https://codereview.chromium.org/1756623002/diff/80001/third_party/WebKit/Source/modules/worklet/WorkletConsole.idl#newcode6 third_party/WebKit/Source/modules/worklet/WorkletConsole.idl:6: // https://developer.chrome.com/devtools/docs/console-api On 2016/03/04 11:02:05, philipj_UTC7 wrote: > It ...
4 years, 9 months ago (2016-03-07 01:15:28 UTC) #8
philipj_slow
LGTM, but can you also update the comment/URL in Window.idl? https://codereview.chromium.org/1756623002/diff/100001/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.idl File third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.idl (right): https://codereview.chromium.org/1756623002/diff/100001/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.idl#newcode13 ...
4 years, 9 months ago (2016-03-07 04:57:04 UTC) #9
ikilpatrick
On 2016/03/07 04:57:04, philipj_UTC7 wrote: > LGTM, but can you also update the comment/URL in ...
4 years, 9 months ago (2016-03-07 20:21:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756623002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756623002/120001
4 years, 9 months ago (2016-03-07 20:34:02 UTC) #13
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-07 21:19:06 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 21:20:31 UTC) #17
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/3ee8e9378635a5859b033bb27729491447a4f4e4
Cr-Commit-Position: refs/heads/master@{#379645}

Powered by Google App Engine
This is Rietveld 408576698