Fix bug for createImageBitmap(HTMLImageElement, premultiplyAlpha=false)

third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp
diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
index fcd2d4a9d531e6de3f90c32fb63135eae31aa098..02285ad626d1f0a0fb34dd886bdc4f8020af0b14 100644
--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
@@ -165,7 +165,7 @@ ImageBitmap::ImageBitmap(HTMLImageElement* image, const IntRect& cropRect, Docum
     bool flipY;
     parseOptions(options, flipY);
 
-    m_image = cropImage(image->cachedImage()->image(), cropRect, flipY, m_isPremultiplied);
+    m_image = cropImage(image->cachedImage()->image(), cropRect, flipY, m_isPremultiplied, false);

[Justin Novosad, 2016/03/02 17:19:25]

Poor readability.  You have two options:
1) Change the bool argument to use an enum to make litteral arguments at the
call site more readable.
2) Use an intermediate variable: 
bool isBitmapPremultiplied = false
cropImage(..., isBitmapPremultiplied);

1) is generally preferred especially for public methods, but might be overkill
in this case.

[xidachen, 2016/03/02 18:00:57]

Agreed, using enum makes more sense IMO.

     if (!m_image)
         return;
     m_image->setOriginClean(!image->wouldTaintOrigin(document->securityOrigin()));