Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1756573002:
[Reland] Fix SkTwoPointConicalGradient zero-radius handling (Closed)
Description[Reland] Fix SkTwoPointConicalGradient zero-radius handling
r == 0 is within valid gradient range, we shouldn't skip it.
BUG=skia:5023
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1756573002
Committed: https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2
Committed: https://skia.googlesource.com/skia/+/5edf82e651630308f99b65506eaff0bb17c88e79
Patch Set 1 #Patch Set 2 : unit test duplication #Patch Set 3 : avoid all-zero radius instantiation #
Messages
Total messages: 26 (12 generated)
Description was changed from ========== Fix SkTwoPointConicalGradient zero-radius handling r == 0 is within valid gradient range, we shouldn't skip it. BUG=skia:5023 R=caryclark@google.com,reed@google.com ========== to ========== Fix SkTwoPointConicalGradient zero-radius handling r == 0 is within valid gradient range, we shouldn't skip it. BUG=skia:5023 R=caryclark@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756573002/1
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756573002/20001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756573002/20001
Message was sent while issue was closed.
Description was changed from ========== Fix SkTwoPointConicalGradient zero-radius handling r == 0 is within valid gradient range, we shouldn't skip it. BUG=skia:5023 R=caryclark@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Fix SkTwoPointConicalGradient zero-radius handling r == 0 is within valid gradient range, we shouldn't skip it. BUG=skia:5023 R=caryclark@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1754113003/ by fmalita@google.com. The reason for reverting is: One layout test shows a regression: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/....
Message was sent while issue was closed.
Description was changed from ========== Fix SkTwoPointConicalGradient zero-radius handling r == 0 is within valid gradient range, we shouldn't skip it. BUG=skia:5023 R=caryclark@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2 ========== to ========== Fix SkTwoPointConicalGradient zero-radius handling r == 0 is within valid gradient range, we shouldn't skip it. BUG=skia:5023 R=caryclark@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2 ==========
Description was changed from ========== Fix SkTwoPointConicalGradient zero-radius handling r == 0 is within valid gradient range, we shouldn't skip it. BUG=skia:5023 R=caryclark@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2 ========== to ========== [Reland] Fix SkTwoPointConicalGradient zero-radius handling r == 0 is within valid gradient range, we shouldn't skip it. BUG=skia:5023 R=caryclark@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2 ==========
Updated to disallow degenerates with r0 == r1 == 0. (prevents artifacts as seen at https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...) PTAL
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756573002/40001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756573002/40001
Message was sent while issue was closed.
Description was changed from ========== [Reland] Fix SkTwoPointConicalGradient zero-radius handling r == 0 is within valid gradient range, we shouldn't skip it. BUG=skia:5023 R=caryclark@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2 ========== to ========== [Reland] Fix SkTwoPointConicalGradient zero-radius handling r == 0 is within valid gradient range, we shouldn't skip it. BUG=skia:5023 R=caryclark@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/9c0b02a557e9be663a0eb07519e1b6a61a6c3df2 Committed: https://skia.googlesource.com/skia/+/5edf82e651630308f99b65506eaff0bb17c88e79 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/5edf82e651630308f99b65506eaff0bb17c88e79 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
