Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1756563002: Fix #465 (Closed)

Created:
4 years, 9 months ago by vsm
Modified:
4 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix #465 This preserves the type when cloning an AdjacentStrings node. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a585af7e0941df972e75965c709b8a685571a160

Patch Set 1 #

Patch Set 2 : Format #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M lib/src/info.dart View 1 1 chunk +10 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
vsm
https://codereview.chromium.org/1756563002/diff/20001/lib/src/info.dart File lib/src/info.dart (right): https://codereview.chromium.org/1756563002/diff/20001/lib/src/info.dart#newcode106 lib/src/info.dart:106: AdjacentStrings visitAdjacentStrings(AdjacentStrings node) { Should this be fixed upstream?
4 years, 9 months ago (2016-03-01 20:46:51 UTC) #3
Jennifer Messerly
LGTM https://codereview.chromium.org/1756563002/diff/20001/lib/src/info.dart File lib/src/info.dart (right): https://codereview.chromium.org/1756563002/diff/20001/lib/src/info.dart#newcode106 lib/src/info.dart:106: AdjacentStrings visitAdjacentStrings(AdjacentStrings node) { On 2016/03/01 20:46:51, vsm ...
4 years, 9 months ago (2016-03-01 20:51:10 UTC) #4
vsm
On 2016/03/01 20:51:10, John Messerly wrote: > LGTM > > https://codereview.chromium.org/1756563002/diff/20001/lib/src/info.dart > File lib/src/info.dart (right): ...
4 years, 9 months ago (2016-03-01 21:07:51 UTC) #5
vsm
4 years, 9 months ago (2016-03-01 21:08:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a585af7e0941df972e75965c709b8a685571a160 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698