src/gpu/vk/GrVkPipeline.cpp - Issue 1756493002: Use VkPipelineCaches during VkPipeline creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkPipeline.cpp

Issue 1756493002: Use VkPipelineCaches during VkPipeline creation (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/vk/GrVkPipeline.cpp

diff --git a/src/gpu/vk/GrVkPipeline.cpp b/src/gpu/vk/GrVkPipeline.cpp

index f009eaf5481c69311b5e16975cba4265ee344c89..7a93071b460cf9f61c378b144ea08d4b56843624 100644

--- a/src/gpu/vk/GrVkPipeline.cpp

+++ b/src/gpu/vk/GrVkPipeline.cpp

@@ -430,7 +430,8 @@ GrVkPipeline* GrVkPipeline::Create(GrVkGpu* gpu, const GrPipeline& pipeline,

int shaderStageCount,

GrPrimitiveType primitiveType,

const GrVkRenderPass& renderPass,

- VkPipelineLayout layout) {

+ VkPipelineLayout layout,

+ VkPipelineCache cache) {

VkPipelineVertexInputStateCreateInfo vertexInputInfo;

VkVertexInputBindingDescription bindingDesc;

// TODO: allocate this based on VkPhysicalDeviceLimits::maxVertexInputAttributes

@@ -490,7 +491,7 @@ GrVkPipeline* GrVkPipeline::Create(GrVkGpu* gpu, const GrPipeline& pipeline,

VkPipeline vkPipeline;

VkResult err = GR_VK_CALL(gpu->vkInterface(), CreateGraphicsPipelines(gpu->device(),

- nullptr, 1,

+ cache, 1,

&pipelineCreateInfo,

nullptr, &vkPipeline));

if (err) {