Option, checkbox and radio should support ':default' selector

third_party/WebKit/Source/core/html/HTMLInputElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
@@ skipping 1637 matching lines @@
 bool HTMLInputElement::isEnumeratable() const
 {
     return m_inputType->isEnumeratable();
 }
 
 bool HTMLInputElement::supportLabels() const
 {
     return m_inputType->isInteractiveContent();
 }
 
+bool HTMLInputElement::isDefaultButtonForForm() const
+{
+    if (fastHasAttribute(checkedAttr))

[tkent, 2016/03/03 13:29:08]

The specification says "input elements to which the checked attribute applies"
but this code doesn't check it.  

Please add InputType::matchesDefaultPseudoClass(), then
 - HTMLInputElement::isDefaultButtonForForm() just calls
m_inputType->matchesDefaultPseudoClass().
 - BaseCheckableInputType::matchesDefaultPseudoClass() checkes
fastHasAttribute(checkedAttr)
 - BaseButtonInputType::isDefaultButtonForForm() checks
|isSuccessfulSubmitButton() && element().form() &&
element().form()->defaultButton() == &element()| (copy the logic of
HTMLFormControlElement::isDefaultButtonForForm)
 - Copy HTMLFormControlElement::isDefaultButtonForForm to
HTMLButtonElement::isDefaultButtonForForm
 - Remove HTMLFormControlElement::isDefaultButtonForForm

[ramya.v, 2016/03/04 06:31:45]

Done.

+        return true;
+    return HTMLFormControlElement::isDefaultButtonForForm();
+}
+
 bool HTMLInputElement::shouldAppearChecked() const
 {
     return checked() && m_inputType->isCheckable();
 }
 
 void HTMLInputElement::setPlaceholderVisibility(bool visible)
 {
     m_isPlaceholderVisible = visible;
 }
 
@@ skipping 260 matching lines @@
 void HTMLInputElement::ensurePrimaryContent()
 {
     m_inputTypeView->ensurePrimaryContent();
 }
 
 bool HTMLInputElement::hasFallbackContent() const
 {
     return m_inputTypeView->hasFallbackContent();
 }
 } // namespace blink