third_party/WebKit/LayoutTests/fast/css/pseudo-default-005.html - Issue 1756483005: Option, checkbox and radio should support ':default' selector

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/pseudo-default-005.html

Issue 1756483005: Option, checkbox and radio should support ':default' selector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
	tkent 2016/03/03 13:29:07 Please do not add \|-005\| to the file name. It's h Please do not add \|-005\| to the file name. It's hard to understand what's tested. Separate it to pseudo-default-checkbox-radio.html and pseudo-default-option.html. ramya.v 2016/03/04 06:31:45 Done. Show quoted text On 2016/03/03 13:29:07, tkent wrote: > Please do not add \|-005\| to the file name. It's hard to understand what's > tested. > Separate it to pseudo-default-checkbox-radio.html and > pseudo-default-option.html. Done.
	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>
	tkent 2016/03/03 13:29:07 I recommend to use testharness.js for new conforma I recommend to use testharness.js for new conformance tests. ramya.v 2016/03/04 06:31:45 Done. Show quoted text On 2016/03/03 13:29:07, tkent wrote: > I recommend to use testharness.js for new conformance tests. Done.
	5 <style>

	6 input:default { background: lime; }

	7 option:default { background: lime; }

	8 input { background: red; }

	9 option { background: red; }

	10 </style>

	11 </head>

	12 <body>

	13 <p id="description"></p>

	14 <form method="get">

	15 <input name="y" type="checkbox" checked />

	16 <input name="n" type="checkbox" />

	17 <input name="n" type="radio" />

	18 <input name="y" type ="radio" checked />
	tkent 2016/03/03 13:29:07 Add more cases: - other input types with 'checke Add more cases: - other input types with 'checked' attribute (This Patch Set fails for them) - checkbox/radio without 'checked' attribute, but checked by 'checked' property ramya.v 2016/03/04 06:31:45 Done. Show quoted text On 2016/03/03 13:29:07, tkent wrote: > Add more cases: > - other input types with 'checked' attribute (This Patch Set fails for them) > - checkbox/radio without 'checked' attribute, but checked by 'checked' > property Done.
	19 <select>

	20 <option name="n">1</option>

	21 <option name="y" selected>2</option>
	tkent 2016/03/03 13:29:08 Add another case: - OPTION without selected attr Add another case: - OPTION without selected attribute, but selected by 'selected' property. ramya.v 2016/03/04 06:31:45 Done. Show quoted text On 2016/03/03 13:29:08, tkent wrote: > Add another case: > - OPTION without selected attribute, but selected by 'selected' property. Done.
	22 </select>

	23 </form>

	24 <div id="console"></div>

	25 <script>

	26 description("This test performs a check for the input types having checked attri bute and option elements having selected attributes to be considered for :defaul t CSS selector.");

	27

	28 u = document.getElementsByName("n");

	29 for (i = 0; i < u.length; i++)

	30 shouldBe("document.defaultView.getComputedStyle(u[i], null).getPropertyValue ('background-color')", "'rgb(255, 0, 0)'");
	tkent 2016/03/03 13:29:08 You can simply check \|shouldBeFalse("u[i].matches( You can simply check \|shouldBeFalse("u[i].matches(':default')")\|. ramya.v 2016/03/04 06:31:45 Done. Show quoted text On 2016/03/03 13:29:08, tkent wrote: > You can simply check \|shouldBeFalse("u[i].matches(':default')")\|. Done.
	31 v = document.getElementsByName("y");

	32 for (i = 0; i < v.length; i++)

	33 shouldBe("document.defaultView.getComputedStyle(v[i], null).getPropertyValue ('background-color')", "'rgb(0, 255, 0)'");

	34 </script>

	35 </body>

	36 </html>

OLD	NEW