Merge to M49: openjpeg: Prevent bad cast in opj_j2k_update_image_data

third_party/libopenjpeg20/j2k.c

 /*
  * The copyright in this software is being made available under the 2-clauses 
  * BSD License, included below. This software may be subject to other third 
  * party and contributor rights, including patent rights, and no such rights
  * are granted under this license.
  *
  * Copyright (c) 2002-2014, Universite catholique de Louvain (UCL), Belgium
  * Copyright (c) 2002-2014, Professor Benoit Macq
  * Copyright (c) 2001-2003, David Janssens
  * Copyright (c) 2002-2003, Yannick Verschueren
@@ skipping 8193 matching lines @@
 
                 /*-----*/
                 /* Compute the area (l_offset_x0_src, l_offset_y0_src, l_offset_x1_src, l_offset_y1_src)
                  * of the input buffer (decoded tile component) which will be move
                  * in the output buffer. Compute the area of the output buffer (l_start_x_dest,
                  * l_start_y_dest, l_width_dest, l_height_dest)  which will be modified
                  * by this input area.
                  * */
                 assert( l_res->x0 >= 0);
                 assert( l_res->x1 >= 0);
+
+                /* Prevent bad casting to unsigned values in the subsequent lines. */
+                if ( l_res->x0 < 0 || l_res->x1 < 0 || l_res->y0 < 0 || l_res->y1 < 0 ) {
+                        return OPJ_FALSE;
+                }
+
                 if ( l_x0_dest < (OPJ_UINT32)l_res->x0 ) {
                         l_start_x_dest = (OPJ_UINT32)l_res->x0 - l_x0_dest;
                         l_offset_x0_src = 0;
 
                         if ( l_x1_dest >= (OPJ_UINT32)l_res->x1 ) {
                                 l_width_dest = l_width_src;
                                 l_offset_x1_src = 0;
                         }
                         else {
                                 l_width_dest = l_x1_dest - (OPJ_UINT32)l_res->x0 ;
@@ skipping 2580 matching lines @@
                         return OPJ_FALSE;
                 }
                 if (! opj_j2k_post_write_tile(p_j2k,p_stream,p_manager)) {
                         opj_event_msg(p_manager, EVT_ERROR, "Error while opj_j2k_post_write_tile with tile index = %d\n", p_tile_index);
                         return OPJ_FALSE;
                 }
         }
 
         return OPJ_TRUE;
 }