Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 1756433002: [api] Don't go to javascript to construct API functions (Closed)

Created:
4 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Don't go to javascript to construct API functions BUG= R=bmeurer@chromium.org,verwaest@chromium.org Committed: https://crrev.com/21a5bfbd2ced6e4a3545bbde712630c0d8734c0b Cr-Commit-Position: refs/heads/master@{#34411}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -37 lines) Patch
M src/builtins.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/execution.cc View 1 2 2 chunks +39 lines, -29 lines 0 comments Download
M src/objects.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
jochen (gone - plz use gerrit)
4 years, 9 months ago (2016-03-01 14:37:15 UTC) #1
Toon Verwaest
https://codereview.chromium.org/1756433002/diff/1/src/execution.cc File src/execution.cc (right): https://codereview.chromium.org/1756433002/diff/1/src/execution.cc#newcode184 src/execution.cc:184: if (!constructor->IsConstructor() && Move up to the fast-path in ...
4 years, 9 months ago (2016-03-01 17:30:35 UTC) #2
jochen (gone - plz use gerrit)
ptal
4 years, 9 months ago (2016-03-01 18:09:57 UTC) #3
Toon Verwaest
Lgtm, but what about just moving that block into the fast-path in Invoke rather than ...
4 years, 9 months ago (2016-03-01 18:17:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756433002/40001
4 years, 9 months ago (2016-03-01 19:40:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/2184)
4 years, 9 months ago (2016-03-01 19:56:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756433002/40001
4 years, 9 months ago (2016-03-01 20:40:36 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-01 20:58:08 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/21a5bfbd2ced6e4a3545bbde712630c0d8734c0b Cr-Commit-Position: refs/heads/master@{#34411}
4 years, 9 months ago (2016-03-01 20:58:55 UTC) #14
Michael Achenbach
4 years, 9 months ago (2016-03-02 07:35:13 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1758623002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks webkit unittests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

Powered by Google App Engine
This is Rietveld 408576698