Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1756413003: [runtime] Rename IsUndetectableObject to IsUndetectable. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Rename IsUndetectableObject to IsUndetectable. This is more consistent with the current naming scheme (i.e. IsCallable for callable bit on map, IsConstructor for constructor bit on map, and now IsUndetectable for undetectable bit on map). Also simplify the fallthrough case for Object::Equals, because we don't need to check for Null or Undefined or Undetectable, as both Null and Undefined already have the undetectable bit set on their maps. R=machenbach@chromium.org Committed: https://crrev.com/0b3e436aa5e66e425d63fa725acbc1bbc0d7cc8c Cr-Commit-Position: refs/heads/master@{#34458}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -32 lines) Patch
M src/code-stubs.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen-types.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic-state.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 10 chunks +10 lines, -12 lines 2 comments Download
M src/objects-inl.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-03 07:57:13 UTC) #1
Benedikt Meurer
Hey Michael, Easy refactoring and a simplification for Object::Equals. Please take a look. Thanks, Benedikt
4 years, 9 months ago (2016-03-03 07:58:05 UTC) #2
Michael Achenbach
lgtm https://codereview.chromium.org/1756413003/diff/1/src/objects.cc File src/objects.cc (left): https://codereview.chromium.org/1756413003/diff/1/src/objects.cc#oldcode374 src/objects.cc:374: (x->IsNull() || x->IsUndefined() || x->IsUndetectableObject()) && This change ...
4 years, 9 months ago (2016-03-03 08:07:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756413003/1
4 years, 9 months ago (2016-03-03 08:09:25 UTC) #6
Benedikt Meurer
https://codereview.chromium.org/1756413003/diff/1/src/objects.cc File src/objects.cc (left): https://codereview.chromium.org/1756413003/diff/1/src/objects.cc#oldcode374 src/objects.cc:374: (x->IsNull() || x->IsUndefined() || x->IsUndetectableObject()) && This is the ...
4 years, 9 months ago (2016-03-03 08:09:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 08:24:46 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 08:26:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b3e436aa5e66e425d63fa725acbc1bbc0d7cc8c
Cr-Commit-Position: refs/heads/master@{#34458}

Powered by Google App Engine
This is Rietveld 408576698