Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1756413002: cc: Disable image hijack canvas when we don't have images in the map. (Closed)

Created:
4 years, 9 months ago by vmpstr
Modified:
4 years, 9 months ago
Reviewers:
enne (OOO), ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Disable image hijack canvas when we don't have images in the map. This patch ensures that we don't use the hijack canvas when there are no images in the discardable map, since this is the way we "disable" things on android. Note we already do this in PlaybackToSharedCanvas, so this is just ensuring that we also do that in PlaybackToCanvas. BUG=591246 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/afb46c11bdde02fe8cd4a76ae5b08e30543d6255 Cr-Commit-Position: refs/heads/master@{#378913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M cc/playback/display_list_raster_source.cc View 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vmpstr
Please take a look.
4 years, 9 months ago (2016-03-02 23:48:35 UTC) #3
ericrk
lgtm
4 years, 9 months ago (2016-03-03 00:27:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1756413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1756413002/1
4 years, 9 months ago (2016-03-03 00:30:57 UTC) #6
enne (OOO)
lgtm2, but wow this is worrisome for how expensive the canvas is.
4 years, 9 months ago (2016-03-03 01:19:40 UTC) #7
vmpstr
On 2016/03/03 01:19:40, enne wrote: > lgtm2, but wow this is worrisome for how expensive ...
4 years, 9 months ago (2016-03-03 01:21:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 01:48:39 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 01:49:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afb46c11bdde02fe8cd4a76ae5b08e30543d6255
Cr-Commit-Position: refs/heads/master@{#378913}

Powered by Google App Engine
This is Rietveld 408576698