Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1756393002: Fix some service protocol isolate lifecycle races (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/isolate_summary.html ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 6742642b837ab8bb72f7c1001c5099a39da283b3..567cf26c72ff101d0befcf9b7759b70a90fc32c4 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1512,6 +1512,7 @@ class Isolate extends ServiceObjectOwner {
case ServiceEvent.kPauseBreakpoint:
case ServiceEvent.kPauseInterrupted:
case ServiceEvent.kPauseException:
+ case ServiceEvent.kNone:
case ServiceEvent.kResume:
assert((pauseEvent == null) ||
!event.timestamp.isBefore(pauseEvent.timestamp));
@@ -1821,6 +1822,7 @@ class ServiceEvent extends ServiceObject {
static const kPauseBreakpoint = 'PauseBreakpoint';
static const kPauseInterrupted = 'PauseInterrupted';
static const kPauseException = 'PauseException';
+ static const kNone = 'None';
static const kResume = 'Resume';
static const kBreakpointAdded = 'BreakpointAdded';
static const kBreakpointResolved = 'BreakpointResolved';
@@ -1863,7 +1865,8 @@ class ServiceEvent extends ServiceObject {
kind == kPauseExit ||
kind == kPauseBreakpoint ||
kind == kPauseInterrupted ||
- kind == kPauseException);
+ kind == kPauseException ||
+ kind == kNone);
}
void _update(ObservableMap map, bool mapIsRef) {
« no previous file with comments | « runtime/observatory/lib/src/elements/isolate_summary.html ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698