Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: runtime/vm/service.cc

Issue 1756393002: Fix some service protocol isolate lifecycle races (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 4fbb0c523408c37143c991d33b293f046a9ce556..f309d4c2381a9c35516358e9ba5f9bce60c710c3 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -3014,6 +3014,16 @@ static bool Resume(Thread* thread, JSONStream* js) {
PrintSuccess(js);
return true;
}
+ if (isolate->message_handler()->should_pause_on_start()) {
+ isolate->message_handler()->set_should_pause_on_start(false);
+ isolate->SetResumeRequest();
+ if (Service::debug_stream.enabled()) {
+ ServiceEvent event(isolate, ServiceEvent::kResume);
+ Service::HandleEvent(&event);
+ }
+ PrintSuccess(js);
+ return true;
+ }
if (isolate->message_handler()->is_paused_on_exit()) {
isolate->message_handler()->set_should_pause_on_exit(false);
isolate->SetResumeRequest();

Powered by Google App Engine
This is Rietveld 408576698